Deploying Graphql about sanity-plugin-mux-input HOT 5 CLOSED

Found it! with @KimPaow 😅

media-chrome will try to detect server-side environments and shim out the window functionality that it relies upon in order to prevents things like this. It does so by using this windowShim

The problem is here

export const isServer = !!(typeof window === 'undefined')
export const Window = isServer ? windowShim : window;

It turns out, in this sanity environment where the sanity graphql deploy command gets run window is not undefined. There already is a window defined, however that window does not have customElements. That's why it leads to this error of Cannot read property 'get' of undefined

I think the solution here might be for media-chrome to do a more robust check for isServer instead of checking !!(typeof window === 'undefined) we could do something more like:

export const isServer = !!(typeof window === 'undefined' || typeof window.customElements === 'undefined')

from sanity-plugin-mux-input.

Thanks @KimPaow and @rexxars !

from sanity-plugin-mux-input.

@And3y thanks for surfacing, we'll take a look at this!

from sanity-plugin-mux-input.

This has now been fixed in media-chrome v0.1.1, but we're depending on v0.0.15. I'm guessing we'll have to upgrade the dependency here as well?

from sanity-plugin-mux-input.

@judofyr Yes, we're working on this and you should see a new release very soon.

from sanity-plugin-mux-input.