`Context.arg` Wraps Optional Arguments inside another Option about sangria HOT 4 CLOSED

@yanns - No worries and I also just came back from my holiday.

As suggested, I raised #952 to demonstrate the unexpected behaviours related to arbitrary input objects and Args. From what I can see, the tests indicate the following:

• build with custom input argument: arguments of custom input types work fine as long as they are not optional;
• build with optional custom input argument and defined input: optional arguments of custom input types wrap the optional results inside another Option (e.g. Some(Some(CustomInput("Hello Sangria"))));

The findings above match what I observed previously, although circeDecoderFromInput from sangria-circe was used in my original code snippet, but I'm using argonautDecoderFromInput from sangria-argonaut in the tests to be consistent with other existing ones.

from sangria.

@yanns - Amazing! @@ InputObjectResult does fix the problem!

It makes sense to me now that we need the @@ tags in the following argument scenarios:

• Optional Object types: Argument[Option[EchoMessageInput @@ InputObjectResult]]
• Optional Scala types: Argument[Option[Int @@ CoercedScalaResult]]

Thanks so much for your help!

from sangria.

Thanks for the detailed report. Sorry I missed the notification somehow.
At first sight, I thought it was similar to #434
But I'm not totally sure.

Could you open a PR with a failing test in https://github.com/sangria-graphql/sangria/blob/main/modules/core/src/test/scala/sangria/schema/ArgsSpec.scala ?

from sangria.

Thanks a lot for the PR!

By using @@ InputObjectResult, I could make it work: 4d81bbf

Is it something that also fix your case?

from sangria.