Disable gzip by default in nginx about vagrant-spk HOT 7 CLOSED

@zarvox if you can +1 +0 -0 -1 this, I'd be happy to hear that.

@jparyani your sanity-check here might be useful too.

from vagrant-spk.

It's a bit sad to disable gzip everywhere. Is there a way to turn off gzip for only error codes (4xx and 5xx)?

It's worth noting, I would consider this a bug that should probably be fixed in sandstorm-http-bridge. I'm +0 on disabling gzip for now, and then re-enabling it once someone fixes it (see sandstorm-io/sandstorm#289).

from vagrant-spk.

I vaguely feel like the gzipping should be done by WebSession in the Sandstorm platform -- think gzip termination, like TLS termination.

On one hand, apps may want to have opinions about if to gzip a response. On the other hand, I'd be happy enough disabling this in apps and deciding Sandstorm Knows Best.

Thank you for the comment @jparyani ; I can see what you mean that WebSession could be fixed instead. I might gzip off; for now but will think about fixing WebSession instead.

from vagrant-spk.

I am +1 on disabling gzip in the nginx conf for now to unbreak things, with the understanding that we really ought to fix WebSession to provide the original content of the HTTP response, because the app may rely on that content to present useful context about the failure to the user.

from vagrant-spk.

Keep in mind that there's two ways gzip is used: as a transfer encoding (where it is applied on-demand) and as a content encoding (where the resource is actually persisted gzipped and served up directly).

Due to historical bugs in browsers, both are represented in practice using Content-Encoding rather than Transfer-Encoding.

If we disable gzip encoding in nginx, I hope that this does not cause it to unzip already-gzipped content. Assuming not, then this seems fine: our own front-end can add gzip, it shouldn't be the app's responsibility.

It is still a bug in sandstorm-http-bridge that error HTML is allowed to be compressed, though.

from vagrant-spk.

This seems to have struck @nicosomb this evening.

from vagrant-spk.

For @kentonv - This will not cause nginx to actively gunzip things - apparently gunzip on; does that, so I think that covers your concerns.

from vagrant-spk.