Code Monkey home page Code Monkey logo

Comments (6)

SandroHc avatar SandroHc commented on June 15, 2024 1

I'll mark this issue as resolved. Thanks once again for the fix!

from schematic4j.

tigerdan2 avatar tigerdan2 commented on June 15, 2024

Hey, late response for other people who might want to use this api

The issue arises due to incorrect handling of the BlockData format
The Sponge format specifies varint encoding for block data. Meaning multiple bytes may repesent a larger integer

The Sponge schematic Parser in thisnproject does not handle varint decoding, wich results in wrong decoding of schematic with a block pallet that require multiple bytes to be represented in the BlockData byte array.

So the api is the problem.

from schematic4j.

RyanLandDev avatar RyanLandDev commented on June 15, 2024

Hey, late response for other people who might want to use this api

The issue arises due to incorrect handling of the BlockData format The Sponge format specifies varint encoding for block data. Meaning multiple bytes may repesent a larger integer

The Sponge schematic Parser in thisnproject does not handle varint decoding, wich results in wrong decoding of schematic with a block pallet that require multiple bytes to be represented in the BlockData byte array.

So the api is the problem.

I'm facing the same issue, the API appears to mess up with bigger palettes. Worth noting it works perfectly fine for small schematics with smaller block palettes.

This is how my schematic should look:
image

However, when I rebuild the schematic using my program with this library, I get this (screenshot taken from the same location):
image

It seems like it works correctly for the first few layers and kind of fails from there. The issue is not on my end (I think) since I tried putting a random location inside Schematic#getBlock(x, y, z), which returns the wrong block aswell.

from schematic4j.

RyanLandDev avatar RyanLandDev commented on June 15, 2024

@blackjackkent @tigerdan2 A bit late, but I was able to successfully resolve this issue in #2

from schematic4j.

SandroHc avatar SandroHc commented on June 15, 2024

The fix from #2 is now available in schematic4j 1.0.1.

Are you able to upgrade to that version to confirm if the issue has been fixed?

from schematic4j.

RyanLandDev avatar RyanLandDev commented on June 15, 2024

The fix from #2 is now available in schematic4j 1.0.1.

Are you able to upgrade to that version to confirm if the issue has been fixed?

Just upgraded to the new version. The issue has been resolved

from schematic4j.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.