Code Monkey home page Code Monkey logo

Comments (8)

jaredbeck avatar jaredbeck commented on May 25, 2024
bundle | egrep -e '(rubyzip|odf-report|mime-types|nokogiri)'
Using nokogiri 1.10.9
Using mime-types-data 3.2019.1009
Using mime-types 3.3.1
Using rubyzip 2.3.0
Using odf-report 0.7.0

from odf-report.

sandrods avatar sandrods commented on May 25, 2024

I think this is a problem similar to #104. I haven't had the time to look into it, but this week will be OSS week, :-) I'll have a look

from odf-report.

jaredbeck avatar jaredbeck commented on May 25, 2024

Hi Sandro.

I think this is a problem similar to #104.

My gut says, similar maybe, but not exactly the same. #104 describes a problem in META-INF/manifest.xml. However, when I compare the contents of my report.odt (which Word dislikes) with my report_rezipped.odt (which Word likes) there is no difference in manifest.xml.

unzip -vl report.odt 
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
...
     962  Defl:N      266  72% 04-27-2020 20:30 7f41a5b1  META-INF/manifest.xml
...
unzip -vl report_rezipped.odt 
...
     962  Defl:N      266  72% 04-27-2020 20:30 7f41a5b1  META-INF/manifest.xml
...

Note the identical CRC-32 checksum.

I suspect we're using rubyzip incorrectly, but don't have more details yet.

I haven't had the time to look into it, but this week will be OSS week, :-) I'll have a look

Thanks, and please let me know if I can help in any way.

from odf-report.

sandrods avatar sandrods commented on May 25, 2024

Well, I couldn't find any obvious culprits. I'm doing the same rubyzip handling I always did, except editing the MANIFEST.XML for the repeated images.

I still think #104 is related. Altough the OP find a diference in MANIFEST.XML, he removed the "\n" at the end and had to rezip the file. I suspect the reziping solved the problem, not the removal.

I'm gonna try to find a windows machine to run some tests (i'm a mac user).

Could #67 be related also?

from odf-report.

jaredbeck avatar jaredbeck commented on May 25, 2024

Altough the OP find a diference in MANIFEST.XML, he removed the "\n" at the end and had to rezip the file. I suspect the reziping solved the problem, not the removal.

Yeah, it's possible the newline is a red herring.

I'm gonna try to find a windows machine to run some tests (i'm a mac user).

Actually, in my steps-to-reproduce above, I was using Word for Mac. So, you can reproduce this on a mac.

Could #67 be related also?

I'll try the binread patch and see if I can still reproduce the issue.

from odf-report.

jaredbeck avatar jaredbeck commented on May 25, 2024

Could #67 be related also?

I'll try the binread patch and see if I can still reproduce the issue.

After applying this patch, I'm still able to reproduce this issue. Probably, the patch didn't help because I have no images in my template file. 🤦

from odf-report.

sandrods avatar sandrods commented on May 25, 2024

I think I nailed it. Will be releasing 0.7.2 shortly

from odf-report.

jaredbeck avatar jaredbeck commented on May 25, 2024

0.7.2 seems to work for me. I can remove my Rezipper class 🎉 Thanks Sandro.

from odf-report.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.