Comments (5)
The ALBANY_EPETRA ifedefs guard are mainly used to guard Epetra code. If you see parts that are guarded but do not include Epetra code than they can probably be removed. I see this as part of the refactoring to Tpetra, not sure why you see this as a separate issue.
from albany.
This issue was motivated by some confusion on my part regarding the code regarding something specific with the distributed parameters code -- maybe you can explain this to me. Are the specializations templated on PHAL::AlbanyTraits::DistParamDeriv, Traits meant to work when ALBANY_EPETRA_EXE is off? If you look at the code, some of these specializations have ALBANY_EPETRA_EXE guards (the ones that use Epetra objects from the workset, as expected), and some don't. I am wondering if it is safe for me to remove ALBANY_EPETRA_EXE ifdef guards around new code I checked in today that is Epetra-free, or if this is going to cause issues in a no-Epetra build. It seems to me like there should be issues when using distributed parameters when Epetra is turned off b/c, for example, there are ifdef guards in critical functions in PHAL_SeparableScatterScalarResponse_Def.hpp; yet my tests that use distributed parameters run correctly even when Epetra is off.
from albany.
I am wondering if it is safe for me to remove ALBANY_EPETRA_EXE ifdef guards around new code I checked in today that is Epetra-free, or if this is going to cause issues in a no-Epetra build.
I don't know. I guess we should try and see.
It seems to me like there should be issues when using distributed parameters when Epetra is turned off b/c, for example, there are ifdef guards in critical functions in PHAL_SeparableScatterScalarResponse_Def.hpp; yet my tests that use distributed parameters run correctly even when Epetra is off.
There might even be some code that is not used any longer, or maybe in the Tpetra version there is some missing logic so that not all the parts of the sensitivities are computed (but that should not be caused by ifdef guards). I guess it is probably better to first figure out what's wrong with the ATO tests and then we can try to clean the #ifdef guards.
from albany.
I see. This is along the lines of what I was conjecturing. I'll keep this open for a bit until I understand better the behavior with ATO. Then I agree this can be closed and moved to the infrastructure cleanup task/issue.
from albany.
Closing this issue - it will be moved to general Albany infrastructure cleanup issue / task.
from albany.
Related Issues (20)
- Question: where is Omega_h checked out to when it is on? HOT 5
- Internal error building omega_h on attaway HOT 6
- Add Trilinos/Albany rpath to export_albany HOT 5
- Failing Tempus adjoint tests HOT 23
- Omega_h failures in warning-free build HOT 2
- Failing Perlmutter build with Omega_h enabled HOT 9
- Trilinos build error reported on Blake due to issue with Kokkos Macros HOT 5
- Albany warning-free array-bounds error on Blake HOT 1
- Kokkos::vector'is deprecated HOT 9
- Switch trilinos installations to use stk simple fields
- Tpetra CudaUVM flags for when Kokkos_ENABLE_CUDA_UVM goes away
- Undefined references when using new Cuda-UVM flags HOT 9
- Nightly test failures HOT 39
- corePDEs_SideSetLaplacian_3D failing on weaver after epetra removal HOT 6
- Clean up nightlies to turn off Epetra HOT 4
- PyAlbany MatrixOperations test failing in spack nightly HOT 18
- Attaway sems modules are broken, causing those tests to fail
- Failing omegah tests HOT 1
- Compilation errors coming from Omegah in warning-free blake build HOT 2
- Omega_h not compatible with CUDA on Weaver HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from albany.