Code Monkey home page Code Monkey logo

Comments (8)

mengfoobar avatar mengfoobar commented on June 9, 2024 1

@echenley ahh i see. I ended up doing something similar to what @jjkavalam did.
which fixes the issue for most languages, but still have some problems with markup (the prismjs tokenize functions creates some pretty messy stuff for markup). Once that was fixed, got into even more issues with multi-lang syntax such as JSX, HTML PHP...etc.

Once i have a more complete implementation, will submit a pull request.
Thanks a lot for the help! Bummer that the author moved on

from draft-js-prism.

mengfoobar avatar mengfoobar commented on June 9, 2024 1

@mxstbr awesome! I'll clean some stuff up and try to get a PR out this weekend

from draft-js-prism.

mengfoobar avatar mengfoobar commented on June 9, 2024

any updates on this issue? I am having the same problems. Not just with java, but other languages as well

from draft-js-prism.

echenley avatar echenley commented on June 9, 2024

@mengfoobar The linked PR above fixes this issue. I had to fork this library and draft-js-code and updated them to fit my use case. Both are pretty clean and comprehensible.

For the record, I doubt this project is actively maintained anymore since the author no longer uses draft-js: facebookarchive/draft-js#388 (comment)

from draft-js-prism.

mxstbr avatar mxstbr commented on June 9, 2024

I've pinged the author and he's given me commit permissions and publish access on npm to take over maintaining this library. Did you ever get anywhere with that imlementation @mengfoobar?

from draft-js-prism.

mxstbr avatar mxstbr commented on June 9, 2024

Awesome, can't wait @mengfoobar! Let me know if you need any help 😊

from draft-js-prism.

mxstbr avatar mxstbr commented on June 9, 2024

Also, do note that #11, #14 and #18 have attempted to solve this problem, so it'd be great to hear what you think of those solutions and how yours is different/better?

from draft-js-prism.

mxstbr avatar mxstbr commented on June 9, 2024

Since I didn't get any response here and really needed this, I merged #17 which fixes this issue beautifully.

@mengfoobar if you still have some improvements on top of that I'd love to still have that followup PR!

from draft-js-prism.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.