Code Monkey home page Code Monkey logo

Comments (3)

samuelmeuli avatar samuelmeuli commented on August 11, 2024

@druc This should fairly be easy to achieve, only a couple of CSS rules will need to be modified.

I'm not really sure how to improve the UI though. Assigning a max width to the editor would definitely improve the writing experience, but having most of the window filled with the background color might not look great either. I guess it's a trade-off.

I'm definitely open to a PR if you'd like to try out what looks best to you :)

from mini-diary.

druc avatar druc commented on August 11, 2024

Hey @samuelmeuli

Here are two screenshots showing the before & after.

before

after

Changes:

  • a slightly smaller top&bottom padding for the whole app
  • slightly decreased calendar date font size
  • increased entry title from 150% to 180%
  • increased paragraph spacing from 10px to 16px
  • adjusted the page box shadow to make the page stand out even more
  • limited the paragraph length to 680px (about 85-90 characters per line)

Possible issue:

  • vw units are used for padding the editor, and that kind of messes up the width. It is ok if I switch to using px and add a media query?

Let me know what you agree/disagree with and I'll put up a PR later today. 😄

from mini-diary.

samuelmeuli avatar samuelmeuli commented on August 11, 2024

That's definitely better.

I'd rather not have too many different font sizes. I think the <h1>/<p> sizes should be the same for calendar and editor. Maybe increasing the base font size in larger windows would be good though?

Same for the paragraph spacing. I think the current one works well for medium-sized windows. Maybe we should only increase it in larger windows.

vw units are used for padding the editor, and that kind of messes up the width. It is ok if I switch to using px and add a media query?

Yeah, that makes sense.

Thanks for your work on this! Looking forward to the PR 😊

from mini-diary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.