Comments (4)
https://github.com/Samsung/ioter/blob/main/src/common/process_controller.py#L104
The child.wait(timeout=10)
blocks user event.
As the result, 'main.py is not responding' message shown.
I think there are three options to solve this issue.
- remove
child.wait(timeout=10)
from termination func. But, I can't convince that it doesn't make jombi process. So, we have to do many tests. - make thread to execute termination func. But, main should wait termination thread before exit. I think we need to do a lot of job.
- just keep it as current status for stability.
from ioter.
How about showing progress dialog?
It would be more descriptive way to termination process
from ioter.
How about showing progress dialog? It would be more descriptive way to termination process
It's also good idea. My concern is only that this progress dialog will be shown whenever process terminated.
I wonder if it looks good. So, I think we might be able to decide it with a demo.
from ioter.
How about showing progress dialog? It would be more descriptive way to termination process
It's also good idea. My concern is only that this progress dialog will be shown whenever process terminated. I wonder if it looks good. So, I think we might be able to decide it with a demo.
I tried to create a message box while terminating devices. But, it didn't work well.
It seems that all operations was stucked during child.wait(timeout=10)
.
Do you have any idea about that ?
+ ## Check key Press Event ##
+ def mousePressEvent(self, event):
+ print('mousePressEvent')
+ if ProcessController.is_terminating():
+ re = QMessageBox.information(self, "Info", "Please, wait for a few seconds.\nWe are terminating devices safely.",
+ QMessageBox.Ok, QMessageBox.Ok)
+ if re == QMessageBox.Ok:
+ event.accept()
+ else:
+ event.ignore()
from ioter.
Related Issues (20)
- Make the slider move when the user presses the arrow
- Delete things device
- Changing a message when close the device window that onboarding has finished
- Saving logs to file
- [Light Bulb] Max value of color Temp. is different from SmartThings HOT 2
- [Light Bulb] Color Temperature is different HOT 1
- Replace from status label to QStatusBar HOT 1
- [BUG] If generated closing popup isn't clicked when device window closed, the automated test doesn't go any more.
- [AutoOnboarding] Result dialog issue HOT 1
- support ESP32-S2-DevKitM-1 HOT 1
- [WindowCovering] OnFabricRemoved is not handled HOT 1
- [AutoOnboarding] Device dialog is closed when phone disconnects with ioter PC HOT 1
- update OT APIs
- [Window Covering] Not normal operation
- RCP failure when start simulated node HOT 9
- Only one device can be onboarded at a time HOT 1
- Some device's pairing code are duplicated HOT 1
- [BUG] BT interface numbering (hci) can't follow device number HOT 1
- [BUG] Onboarding fails from 2nd device HOT 1
- Remove unused logs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ioter.