Code Monkey home page Code Monkey logo

Comments (4)

junyong-sim avatar junyong-sim commented on May 30, 2024

https://github.com/Samsung/ioter/blob/main/src/common/process_controller.py#L104
The child.wait(timeout=10) blocks user event.
As the result, 'main.py is not responding' message shown.

I think there are three options to solve this issue.

  1. remove child.wait(timeout=10) from termination func. But, I can't convince that it doesn't make jombi process. So, we have to do many tests.
  2. make thread to execute termination func. But, main should wait termination thread before exit. I think we need to do a lot of job.
  3. just keep it as current status for stability.

from ioter.

spdkimo avatar spdkimo commented on May 30, 2024

How about showing progress dialog?
It would be more descriptive way to termination process

from ioter.

junyong-sim avatar junyong-sim commented on May 30, 2024

How about showing progress dialog? It would be more descriptive way to termination process

It's also good idea. My concern is only that this progress dialog will be shown whenever process terminated.
I wonder if it looks good. So, I think we might be able to decide it with a demo.

from ioter.

junyong-sim avatar junyong-sim commented on May 30, 2024

How about showing progress dialog? It would be more descriptive way to termination process

It's also good idea. My concern is only that this progress dialog will be shown whenever process terminated. I wonder if it looks good. So, I think we might be able to decide it with a demo.

I tried to create a message box while terminating devices. But, it didn't work well.
It seems that all operations was stucked during child.wait(timeout=10).
Do you have any idea about that ?

+    ## Check key Press Event ##
+    def mousePressEvent(self, event):
+        print('mousePressEvent')
+        if ProcessController.is_terminating():
+            re = QMessageBox.information(self, "Info", "Please, wait for a few seconds.\nWe are terminating devices safely.",
+                                      QMessageBox.Ok, QMessageBox.Ok)
+            if re == QMessageBox.Ok:
+                event.accept()
+            else:
+                event.ignore()

from ioter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.