Code Monkey home page Code Monkey logo

Comments (6)

ilya-palachev avatar ilya-palachev commented on June 19, 2024

Hi, Anastasia.
Yes, it's a bit tricky heuristics :)

The reason is the following:

  1. --greedy option means that combirepo marks the maximum set of packages, i.e. tries to get as many packages from marked ( = sanitized) repository as possible.
  2. --mirror option means that combirepo gets non-marked packages instead of marked ones, if some package doesn't present in the marked repository.
  3. The error Found 7 packages with different version numbers! is generated by method check_rpm_versions, which checks only marked packages for equality of version numbers (see this line, where it's called). For each marked package this method checks its version number in marked and non-marked repository, and asks the developer to make them equal. If I recall correctly, at the stage of combirepo design and development this feature was needed to prevent image creation with different versions. This is needed to make debugging of package correct: if versions of the package are different, we cannot provide the correctness of its testing in the combined image.

As I guess, libmm-sound-* packages weren't marked when --mirror option was specified, because ks file didn't contain explicit mention of that packages. But with --greedy option, libmm-sound-* packages were marked, and repository combiner checked them for version correspondence.

So you have three options:

  1. Actually rebuild libmm-sound-* packages in marked ( = sanitized) repository, so that to make versions correspond to each other.
  2. Temporarily disable check_rpm_versions and see to what consequences that will lead. I believe that either mic will fail during image creation phase, or there will be some run-time error. Moreover, as I remember, mic error logs about non-equal versions are very strange and hard to debug, because mic reports not the root cause of the error. There is some tricky way to debug it, I can describe if needed.
  3. Implement heuristic that will exclude package from marked set, if there is a version conflict. I.e. take non-marked package if marked one has a version conflict.

Hope this comment will help.

from combirepo.

a-lyupa avatar a-lyupa commented on June 19, 2024

@ilya-palachev,
Thank you for a such detailed response!

from combirepo.

a-lyupa avatar a-lyupa commented on June 19, 2024

@ilya-palachev , @rayslava ,
What if replace critical error of version mismatch with warning, unmark such packages and continue building an image?

from combirepo.

rayslava avatar rayslava commented on June 19, 2024

I don't think that implicitly changing user request is a good idea. At least by default, may be we can add flag to convert it into warning.

from combirepo.

ilya-palachev avatar ilya-palachev commented on June 19, 2024

Maybe, a trade-off would be, when both --mirror and --greedy options are specified, to take non-marked package when its version conflicts with marked one's.

from combirepo.

a-lyupa avatar a-lyupa commented on June 19, 2024

Added a new option to skip version mismatch
#9

from combirepo.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.