Remove tests from autoloading about whiteoctoberpagerfantabundle HOT 10 CLOSED

This only happens when you generate a class-map, you can add an exclude-from-classmap for this.

"autoload": {
    "psr-4": { "WhiteOctober\\PagerfantaBundle\\": "" }
},
"exclude-from-classmap": [
    "Tests",
    "TestsProject"
]

And it's generally recommended to use a .gitattribute (which is properly what @SpacePossum meant 😉 ):

/Tests export-ignore
/TestsProject export-ignore

Which also makes the distribution file much smaller.

from whiteoctoberpagerfantabundle.

This is now fixed in release https://github.com/whiteoctober/WhiteOctoberPagerfantaBundle/releases/tag/v1.1.3.

from whiteoctoberpagerfantabundle.

Hi @sampart , no worries and no apologies needed, thank you guys for this bundle and for all the time you've committed to it 👍
I created a PR in the hope to resolve this, lets see how it goes :)

(PS. @delboy1978uk you should be able to update to 2.1 I think, as the tests are not an issue there)

from whiteoctoberpagerfantabundle.

Thanks!

from whiteoctoberpagerfantabundle.

We are stuck on v1.0.0 because of this. Tried the exclude thing in our json, with no success.

from whiteoctoberpagerfantabundle.

FYI, I fixed it by manually specifying which AppKernel class to use (our one!)

"autoload": {
        "psr-4": { "": "src/" },
        "classmap": [ "app/AppKernel.php", "app/AppCache.php" ]
    },

But seriously, your test stuff should not interfere like this! Give that file a namespace! :-D

from whiteoctoberpagerfantabundle.

@pablodip is this still maintained, would you welcome a PR to resolve this issue?

from whiteoctoberpagerfantabundle.

@SpacePossum thanks for your involvement with this so far. You're right that the project is suffering from a lack of available time on our behalf. If you were able to create a PR, that would be great. Sorry not to have had more time to look at this one.

from whiteoctoberpagerfantabundle.

And it's generally recommended to use a .gitattribute

This is true, but it won't stop the Tests folder etc from appearing if someone runs composer with --prefer-source, of if it has trouble getting the distributed version, and it uses the source as a fall-back.

from whiteoctoberpagerfantabundle.

closing as this is fixed :)

from whiteoctoberpagerfantabundle.