Comments (3)
It's been a while, but iirc at the time the socket was handling all timeouts and the parent (request) did not always process correctly. By listening directly on the socket you'd basicly bypass the whole problem.
In which node version are you getting this error?
The commit is from 2 years ago, that was probably node v0.12, so maybe they finally fixed the request problem in recent versions.
from node-httpreq.
I'm currently using node v6.10.1
Problem is that the socket stays 'alive' and timeout handlers keep adding up. So to fix that, we would have to keep a reference of the socket object, keep a reference to the timeout handler and then remove the timeout handler from the socket the moment the request ends.
We'll see if this comes up as an issue using request.setTimeout()
from node-httpreq.
Okay.
from node-httpreq.
Related Issues (12)
- 'close' event
- corrupt binary uploads - headers inserted at top of file on the target HOT 6
- Clean up the code HOT 2
- node-httpreq exception HOT 1
- File handles not closed when there are redirects during the download of a file HOT 1
- Support for the OPTIONS method
- Post parameters with multiple values. HOT 3
- proxy with username & password handling HOT 1
- Added 'head' support HOT 1
- Downloaded files can end truncated
- Cipher Shuffling as implemented can end up sending old, slow, or insecure ciphers as top preference
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-httpreq.