`mountPath` integration test fails when run alone about samba-operator HOT 3 CLOSED

The smbclient is automatically created by the deploy test which is the first test run in the integration suite.
https://github.com/samba-in-kubernetes/samba-operator/blob/master/tests/integration/integration_test.go#L22

Therefore it is unlikely that the complete set of tests would fail because of ordering of the tests. However the individual tests will fail. The proposed set of patches fixes this issue.

from samba-operator.

To test:

Ensure no smbclient pod exists in testnamespace before running test.

Problematic:

[sprabhu@t10 samba-operator]$ SMBOP_TEST_RUN=TestIntegration/smbShares/mountPath tests/test.sh
=== RUN TestIntegration
=== RUN TestIntegration/smbShares
=== RUN TestIntegration/smbShares/mountPath
mount_path_test.go:70:
Error Trace: mount_path_test.go:70
suite.go:118
integration_test.go:15
Error: Received unexpected error:
failed to flush cache: ['rm' '-f' '/var/lib/samba/lock/gencache.tdb']: failed executing command (pod:samba-operator-system/smbclient container:client): pods "smbclient" not found [exit: 1; stdout: ; stderr: ]
Test: TestIntegration/smbShares/mountPath
--- FAIL: TestIntegration (22.47s)
--- FAIL: TestIntegration/smbShares (22.47s)
--- FAIL: TestIntegration/smbShares/mountPath (22.47s)
FAIL
FAIL github.com/samba-in-kubernetes/samba-operator/tests/integration 22.490s
FAIL

After fix:

[sprabhu@t10 samba-operator]$ make commitid
CommitID: 4f6c850
[sprabhu@t10 samba-operator]$ SMBOP_TEST_RUN=TestIntegration/smbShares/mountPath tests/test.sh
=== RUN TestIntegration
=== RUN TestIntegration/smbShares
=== RUN TestIntegration/smbShares/mountPath
=== RUN TestIntegration/smbShares/mountPath/TestMountPath
--- PASS: TestIntegration (48.75s)
--- PASS: TestIntegration/smbShares (48.75s)
--- PASS: TestIntegration/smbShares/mountPath (48.75s)
--- PASS: TestIntegration/smbShares/mountPath/TestMountPath (0.28s)
PASS
ok github.com/samba-in-kubernetes/samba-operator/tests/integration 48.772s

from samba-operator.

The smbclient is automatically created by the deploy test which is the first test run in the integration suite. https://github.com/samba-in-kubernetes/samba-operator/blob/master/tests/integration/integration_test.go#L22

Therefore it is unlikely that the complete set of tests would fail because of ordering of the tests. However the individual tests will fail. The proposed set of patches fixes this issue.

Sorry, I got a few things mixed up here. The smbclient is created as part of the SmbShareSuite tests and that re-ordering could end up with calling mountPath tests before the smbclient has been started. The proposed patch fixes the issue in any case.

from samba-operator.