RTCIceCandidate format about saltyrtc-meta HOT 8 CLOSED

I agree. The RTCIceCandidate interface should be pretty fixed - I'm not expecting any changes to it for either WebRTC or ORTC. However, they should be treated as individual types.
Also, we want to be independent from the browser's implementations. Thus, the MessagePack serialisation must be crystal clear in the protocol spec.

from saltyrtc-meta.

ORTC:

dictionary RTCIceCandidate {
             DOMString              foundation;
             unsigned long          priority;
             DOMString              ip;
             RTCIceProtocol         protocol;
             unsigned short         port;
             RTCIceCandidateType    type;
             RTCIceTcpCandidateType tcpType;
             DOMString              relatedAddress = "";

WebRTC:

dictionary RTCIceCandidateInit {
    required DOMString      candidate;
             DOMString      sdpMid;
             unsigned short sdpMLineIndex;
};

[ Constructor (RTCIceCandidateInit candidateInitDict)]
interface RTCIceCandidate {
    readonly        attribute DOMString               candidate;
    readonly        attribute DOMString?              sdpMid;
    readonly        attribute unsigned short?         sdpMLineIndex;
    readonly        attribute DOMString               foundation;
    readonly        attribute unsigned long           priority;
    readonly        attribute DOMString               ip;
    readonly        attribute RTCIceProtocol          protocol;
    readonly        attribute unsigned short          port;
    readonly        attribute RTCIceCandidateType     type;
    readonly        attribute RTCIceTcpCandidateType? tcpType;
    readonly        attribute DOMString?              relatedAddress;
    readonly        attribute unsigned short?         relatedPort;
    serializer = {candidate, sdpMid, sdpMLineIndex};
};

It looks like WebRTC uses the candidate string together with sdpMid and/or sdpMLineIndex to create an RTCIceCandidate object. In ORTC you construct that object directly.

From the spec I did not really understand what the sdpMid and sdpMLineIndex do. But we could probably choose the same structure as ORTC and then construct the candidate string from that in WebRTC?

from saltyrtc-meta.

Let's just send the whole RTCIceCandidate instance as defined above as a generic JSON object (serialised to a MessagePack map on the wire and unserialised to a generic JSON object before it's being passed to an onCandidate event) and leave it up to the users which fields they want to use to reconstruct the RTCIceCandidate. The SDP-stuff is not really well explained because it's not meant to be modified and... I don't really understand it either. (Personally I think SDP is an unnecessary burden - that's why I like ORTC.)

from saltyrtc-meta.

Ok, so this would be the RTCIceCandidate?

interface RTCIceCandidate {
    foundation: string,
    priority: number, // unsigned long
    ip: string,
    protocol: 'tcp' | 'udp', // RTCIceProtocol
    port: number, // unsigned short
    type: 'host', 'srflx', 'prflx', 'relay', // RTCIceCandidateType
    tcpType?: 'active' | 'passive' | 'so', // RTCIceTcpCandidateType
    relatedAddress?: string,
    relatedPort?: number, // unsigned short
}

from saltyrtc-meta.

Nearly. We'll also send the fields candidate, sdpMid and sdpMLineIndex in case WebRTC is being used.

from saltyrtc-meta.

Well, but what if both candidate and the other fields are filled out with conflicting information? Which one is authoritative?

If it's easy to deduce the candidate from the fields above, I don't think we should include redundant information.

from saltyrtc-meta.

I'm with you - yes, the information is redundant. But you can't reconstruct an RTCIceCandidate instance without candidate, sdpMid and sdpMLineIndex (see the RTCIceCandidate interface constructor). At least not for WebRTC.

For us, another option would be to just send candidate, sdpMid and sdpMLineIndex for WebRTC and the well defined RTCIceCandidate interface for ORTC (which is also slightly different to the one that WebRTC defines).

from saltyrtc-meta.

That would probably be the best approach for now. The implementors know which library they want to use :)

from saltyrtc-meta.