Comments (5)
Found the issue: children[i].childNodes()[0].toString().trim()
must rather read children[i].childNodes()[0].text().trim()
. I have also fixed another bug caused by the same way of casting the child object to String
using toString()
rather than text()
.
I'll add your test cases to the test suite, however, I'll take a bit until I release the new version as I'm planning to bring the code in line with the rest of my newer node.js libraries. At the moment is bit of a mess.
from libxml-to-js.
Travis won't even build the code even though the test suite is passing on my machine. jslint is bit upset. Can't complain about this though. The last build on Travis was bloody ages ago. This definitely needs a major overhaul.
from libxml-to-js.
Many thanks for the fix. I tested with your "future" branch and confirmed it solves the bug.
from libxml-to-js.
Thank you for confirming. In the mean time, I've done most of the bits I was planning to do including your test cases with Mocha + Chai. The only thing still remaining is to port the existing tests before releasing this as a new version.
from libxml-to-js.
Published v0.3.12. Thanks for your patience.
from libxml-to-js.
Related Issues (13)
- CData HOT 2
- Install on ARM platform HOT 3
- Failed to install with npm HOT 1
- Library does not read CDATA sections HOT 4
- XPath Axes HOT 1
- Error on unstable branch of node (v0.11.7) HOT 1
- Segmentation fault HOT 8
- Node12 issues HOT 2
- Fails to build on Fedora 16/x86_64
- CRITICAL BUG: simple test case losing attribute name HOT 3
- Error Handling HOT 5
- Fails to install via npm HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libxml-to-js.