Code Monkey home page Code Monkey logo

Comments (5)

SaltwaterC avatar SaltwaterC commented on August 15, 2024

Found the issue: children[i].childNodes()[0].toString().trim() must rather read children[i].childNodes()[0].text().trim(). I have also fixed another bug caused by the same way of casting the child object to String using toString() rather than text().

I'll add your test cases to the test suite, however, I'll take a bit until I release the new version as I'm planning to bring the code in line with the rest of my newer node.js libraries. At the moment is bit of a mess.

from libxml-to-js.

SaltwaterC avatar SaltwaterC commented on August 15, 2024

Travis won't even build the code even though the test suite is passing on my machine. jslint is bit upset. Can't complain about this though. The last build on Travis was bloody ages ago. This definitely needs a major overhaul.

from libxml-to-js.

jamesbursa avatar jamesbursa commented on August 15, 2024

Many thanks for the fix. I tested with your "future" branch and confirmed it solves the bug.

from libxml-to-js.

SaltwaterC avatar SaltwaterC commented on August 15, 2024

Thank you for confirming. In the mean time, I've done most of the bits I was planning to do including your test cases with Mocha + Chai. The only thing still remaining is to port the existing tests before releasing this as a new version.

from libxml-to-js.

SaltwaterC avatar SaltwaterC commented on August 15, 2024

Published v0.3.12. Thanks for your patience.

from libxml-to-js.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.