[BUG] 3007.1 Windows Minion file.directory causes No mapping between account names and security IDs was done when off domain about salt HOT 3 OPEN

It looks like it's hitting the issue when trying to calculate changes to the file object here: https://github.com/saltstack/salt/blob/master/salt/states/file.py#L849

from salt.

I'm wondering if https://github.com/saltstack/salt/blob/master/salt/states/file.py#L846 is an inverted if.

The only places _check_directory_win are called from (in the file.py state) are file.directory, file.append, and file.prepend.

I guess I'll have to check if file.append and file.prepend are turning correctly or if they are spitting out changes:

{name: {"directory": "new"}}

from salt.

I see what's going on. It's not inverted.
If the directory doesn't exist, it just lets you know it's a new directory.
If it already exists, it calculates the changes between the existing directory and the state and that's where it fails to find ownership information because the domain is unavailable.

Probably need to wrap it in a try/except for cases when the domain is unavailable.

from salt.