Comments (10)
I guess it is a at least a bit irritating to add a deprecation warning before the alternative is available.
In most pieces of software, a deprecation warning means: “Don’t use this in new code / projects. Use … instead.” But with no alternative being available yet, there is only the choice between using the deprecated module or not configuring Docker via Salt at all. IMO, such a deprecation warning is quite useless.
So, it is debatable whether there should be a deprecation warning at current point in time at all, but if there is supposed to be one, it should rather read: “This module will be removed from Salt in version 3009. An alternative in form of an extension module is going to be provided before the removal.”
from salt.
it is a deprecation in that it will require an install of saltext-docker in 3009 and beyond. not shipped with the core system.
it will be a core saltext not a core module after 3009. meaning that the core team will still be handling the code. and that it will start out from the code that already exists.
but with time it will also mean faster development of the saltext as well as the core system as we move things around and yes turn into a multiple repo system.
from salt.
Thank you for explanation. This all sounds good and reasonable, but could be communicated much better. For example, code could be first moved out of the core into saltext-docker with core having a dependency on saltext-docker. Then after some time that dependency link could get deprecated. And then removed after few versions. Then it would be clear what is being deprecated: the dependency link, not the code/module itself.
from salt.
Same for the link at the top of https://docs.saltproject.io/en/latest/ref/states/all/salt.states.docker_network.html
from salt.
the docker saltext will be just moving the existing code into it's own repo. it will be the same code.
from salt.
The change was introduced #64890, but there is no mention of the failing link there.
I suspect the repo is currently set to private, which is really unfortunate. We are currenty evaluating SaltStack for our application, but without Docker support, we cannot use it.
I would love for some maintainer to confirm that Docker support is going to be available after 3007 (with the extension of course).
from salt.
deprecation does not mean removed. it is just a warning at this point and will be removed in 3009.
docker will be a core extension module in the future.
I can confirm docker still works in 3007. the link is for an upcoming extension module. not one that currently exists.
from salt.
I am in the same boat. I am looking at Salt and now I do not know if I should spend time using Docker with Salt and then how much I will have to rewrite when support moves to saltext-docker? Is this code just moving there, or will saltext-docker be a rewrite and require changes to my states?
from salt.
So you are just changing monorepo project structure to multiple repositories? If docker extension will still stay "core". Maybe then this is not deprecation?
from salt.
Just wanted to pipe in that I for one appreciate the deprecation warning. If you've been with the project for a while you know 3009 is a while away so just seeing that in the "future release" made me smile and immediately ignore it.
"I'm not even mad, I'm impressed"
Love the foresight and the inclination to warn us asap!
Hope the API is similar 🤞
from salt.
Related Issues (20)
- Construct variable from another variables HOT 2
- [FEATURE REQUEST] Include saltexts in Salt-SSH thin archive
- [BUG] debian packages: bash completion script is installed to wrong place
- [BUG] Publishing large event data from scheduled highstate to master via ipc socket hangs and breaks minion in 3005.1 (and 3007.0)
- [BUG] TCP Publish Client encountered an exception while connecting to /var/run/salt/master/master_event_pub.ipc HOT 1
- [BUG] job cache is saved locally even if job_cache is set to False in master config HOT 1
- [BUG] salt-master defunct after API calls using runner client HOT 3
- [BUG] Using IPv6 in 3007.0 causes TCP PublishServer to crash HOT 1
- [BUG] Channels are closed while listened to in 3007.0 HOT 1
- [BUG] salt-ssh breaks on FreeBSD if IFCONFIG_FORMAT is set to return CIDR HOT 1
- [BUG] MySQL Version caching ignores connection_args breaking states the use multiple MySQL servers
- [DOCS] Link to Slack community only works if you have a saltstack.com email address HOT 2
- [BUG] [3007] Salt-master doesn't start when ssl is enabled HOT 2
- [BUG] FIPS mode uses non FIPS algorithms.
- [DOCS] state_top_saltenv documention is inaccurate in regard to when it applies
- [BUG] file_roots to relative path seems broken HOT 1
- [BUG] states from gitfs fail with AttributeError: '_pygit2.Blob' object has no attribute 'oid' with pygit2 1.15.0 HOT 3
- [BUG] [3007] Problem running salt function in Jinja template: Cannot run the event loop while another loop is running HOT 2
- [BUG] [3007.1] startup_states: highstate stop working HOT 1
- [BUG] [Regression] yaml output broken in 3006.8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from salt.