[RESOLVED] API key gives invalid response about topvoter HOT 32 CLOSED

@LordJoshie I asked dktapps about a feature which could return the cURL error in Utils::getURL(). I hope the idea gets accepted. That could help to truly find out what this issue was caused by.

from topvoter.

Removed API-Key due to security reasons - Salmon

from topvoter.

lol, t.y Salmon.... but how is it a security risk ? j.w. :$

from topvoter.

@LordJoshie As far as I know the serverlist claimed that you should never post it somewhere. Anyway, it seems like your API key is invalid.

from topvoter.

I'll try to make the plugin show the response of the serverlist

from topvoter.

from topvoter.

@LordJoshie Try using this link:
https://minecraftpocket-servers.com/api/?object=servers&element=voters&month=current&format=json&key= insert-your-key-here!

from topvoter.

you suggest I use the whole link with my key in the spot without the *'s ?

from topvoter.

@LordJoshie you can test your key with that link. It won't make it work, I just wanted to tell you how I tested it.

from topvoter.

from topvoter.

Hope this won't happen again! :) Added a console message to let people know if their API key is invalid.

from topvoter.

from topvoter.

Hey Salmon, I am home from work now and able to provide anything from my end needed for you to help me resolve this issue...

And my apologies about lastnights/thismornings little messup with the plugin confusion... I was super tired :P

from topvoter.

from topvoter.

after you updated the plugin, this was the new information it gave me... if there is a way I can personally show you my logs and .yml's to compare, and for you to point out what my problem is, I am all for doing that, so my personal information isn't shared here in a public place.

from topvoter.

You could contact him via Telegram or email him ([email protected])

from topvoter.

Oh, try resetting your config.yml for TopVoter and type everything back in (don't cp). I am not sure if this matters, but make sure there is no space in the begging or the end inside the API-Key: 'supersecretkey'

from topvoter.

I don't care much about the api-key being shown, but here... I downloaded Tess, I downloaded TopVoter, and ran it... still get the same issue. so I'm stupid :)

from topvoter.

Sorry to be a bother Salmon, I've literally gone through this way more than I ever thought I would.

With my very small amount of knowledge, I went ahead and picked apart the plugin and it seems that no matter what I do, I will always receive the same errors.

:S

from topvoter.

As you can see here, with some changes to the source plugin, and a test on Tesseract, it DOES in fact work.... however, something due to the way the plugin is calling to/handling the information is the issue I'm having.

Have you made any changes in the past Salmon ?

from topvoter.

@LordJoshie Yup, I also came to the same solution when I saw that the Updater also failed for you. It seems like the way the plugin connects to the internet is broken. I'll guess the Utils::getURL() function has to do with this issue.

from topvoter.

Hey.... Salmon, my friend and I figured it out.

ALL CREDIT GOES TO MY FRIEND... but change the https to just be http. wallah. have a good day.

from topvoter.

@LordJoshie In normal cases https shouldn't cause such issues. But I can't offer another solution yet, so I'll close this now.

from topvoter.

Hey man, if it ain't broke... don't fix it !

And fortunately, you're plugin wasn't broken... just the laws of the internet... so we had to lie a little. :)

from topvoter.

The feature was added into the branch issues/332 at pmmp. As soon as the updater crash of pmmp is fixed, could you test this again with this version of pmmp? I am really interested to fix this issue or just find out, what the cause was.

from topvoter.

Yeah, I'll give this a go now and report my findings.

from topvoter.

I realize why I don't use PocketMine, besides having nothing to offer, it's slow, uses too much resource, and you need to compile the spl/raklib& lang files... holy garbage.

My server is currently frozen because of launching PocketMine. doesn't help I'm doing this off the server I host my public server on... so... whoops.

from topvoter.

@LordJoshie Oh well, I'd always suggest to test things on a test server. Do you need a phar compiled or will you be able to compile from branch issues/332?

Oh and the thing is, you're actually supposed to recursivly download the repository (git clone --recursive https://github.com/pmmp/PocketMine-MP should work). This way submodules will be downloaded, too.

from topvoter.

its compiled... derp. hence when booting it lagged the shit out of my server.

also, I only own one vps... so I create new folders for my test servers... not expecting a program that is default set to use only 512mb of ram, to take up 3gb fro a world generation, and lag up my vps so hard...

still waiting for a response from it.

from topvoter.

Okay, things are fine now...

Regardless, I'm still curious why this needs to be tested... or what you're expecting to get from it.

from topvoter.

@LordJoshie Since I didn't change anything or fix it it could be possible that other people could encounter this issue. If it is avoidable by the code I'd like to change it properly.

I hope Utils::getURL() will return an error message from cURL. It should do with the new pmmp branch when cURL fails.

from topvoter.

Seems to be connected to #26 in retrospective.

from topvoter.