Comments (6)
Sure, I would recommend reading CONTRIBUTING.md.
from lwc.
Alternatively, we could have @lwc/rollup-plugin
just not route .jsx
/.tsx
files to @lwc/compiler
, since @lwc/compiler
doesn't need to compile them anyway. (They cannot possibly be LWC components.)
from lwc.
hey @nolanlawson ,
I have tried fixing it by just checking the file extensions and returning early if file extensions are either .jsx/.tsx. I am not sure whether it'll introduce a breaking changes or not. Can you please verify?
from lwc.
Hi @SaurabhMulay999 thanks for the contribution! However, this fix needs to be made inside of @lwc/compiler
, not @lwc/rollup-plugin
. The Rollup plugin uses the @lwc/compiler
under the hood, but there are other consumers of the compiler (e.g. Webpack, LWR).
As mentioned above, I think the simplest fix would be to add the extensions here. It is not ideal, since .jsx
/.tsx
files are unlikely to need LWC component transformations, and it will assume that someone has set up a tool earlier in the processing pipeline to convert these files into JS, but it seems like the most expedient solution to me.
from lwc.
Thanks @nolanlawson for the details. I'll try what you have suggested. Is there any open doc maintained to get idea of whole project? It would be helpful.
from lwc.
Fixed by #4164
from lwc.
Related Issues (20)
- Normalize whitespace for `style` and `class` attributes (breaking change) HOT 2
- Inline styles do not parse `! important` correctly due to extra whitespace HOT 15
- Bundle our licenses correctly in our npm packages
- lwr project does not run anymore (sudden death) HOT 1
- Use `node:` protocol for all builtin imports (`fs`, `path`, etc.) HOT 1
- Specify the minimum supported version of Node in `engines` HOT 1
- Reduce verbosity in `template.stylesheets` generated code
- Switch from Jest to Vitest HOT 1
- [HMR] `swap*` APIs show stale content when swapping back and forth multiple times HOT 1
- [HMR] `swapStyle()` API does not account for stylesheet collisions
- [HMR] `swapStyle()` does not work for `static stylesheets`
- Executing Static Resources within LWC HOT 1
- Inconsistent attribute ordering between static/dynamic nodes
- Lightning-datatable has wrong type of parameters passed to custom type columns through typeAttributes that passsed not with "fieldName"
- KOA Server Not Able to Add Routes HOT 2
- Lightning datatable admits only 100 records (or something lower than 150, idk) HOT 2
- Add support for dynamic `<slot>` names
- Version mismatch warning should warn for patch version differences as well HOT 1
- `@api` decorated property is not reactive with private class properties HOT 1
- Be homogenous to traverse the parent DOM between shadow dom and `lwc:render-mode="light"` mode
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lwc.