Code Monkey home page Code Monkey logo

Comments (11)

davidturissini avatar davidturissini commented on May 27, 2024 1

@jodarove You can definitely remove from primitive-datatable-tooltip. I looked at datatable/columns and that component will need to be refactored.

from lwc.

caridy avatar caridy commented on May 27, 2024

Do we need to wait until we remove the traverse membrane to be able to remove this? or should we be able to remove this now?

from lwc.

davidturissini avatar davidturissini commented on May 27, 2024

This was added for observable-membrane and was designed to be an escape hatch for lightning-data-table if I believe. I'm not sure we can remove this yet.

from lwc.

caridy avatar caridy commented on May 27, 2024

cc @gonzalocordero @jodarove @reiniergs, can any of you confirm?

from lwc.

jodarove avatar jodarove commented on May 27, 2024

we use it in two places:

1- modules/lightning/datatable/columns
2- modules/lightning/primitive-datatable-tooltip/primitive-datatable-tooltip

I can get why we use it in (1) (and as we speak we plan to remove it). but i don't know why we should use it in (2)

@davidturissini do you have any idea why the second usage?

from lwc.

pmdartus avatar pmdartus commented on May 27, 2024

I don't see any code that is referencing this API anymore in the global components. Is there any other blocker with removing this API?

from lwc.

diervo avatar diervo commented on May 27, 2024

from lwc.

caridy avatar caridy commented on May 27, 2024

let's remove it.

from lwc.

diervo avatar diervo commented on May 27, 2024

I'm hearing that @caridy is volunteering to remove occurrences in core! 🎉

from lwc.

caridy avatar caridy commented on May 27, 2024

there you go diego: #831

now we just need to wait 2 weeks to get this merged 🤣

from lwc.

pmdartus avatar pmdartus commented on May 27, 2024

Fixed by #831

from lwc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.