Comments (11)
@jodarove You can definitely remove from primitive-datatable-tooltip
. I looked at datatable/columns
and that component will need to be refactored.
from lwc.
Do we need to wait until we remove the traverse membrane to be able to remove this? or should we be able to remove this now?
from lwc.
This was added for observable-membrane
and was designed to be an escape hatch for lightning-data-table if I believe. I'm not sure we can remove this yet.
from lwc.
cc @gonzalocordero @jodarove @reiniergs, can any of you confirm?
from lwc.
we use it in two places:
1- modules/lightning/datatable/columns
2- modules/lightning/primitive-datatable-tooltip/primitive-datatable-tooltip
I can get why we use it in (1) (and as we speak we plan to remove it). but i don't know why we should use it in (2)
@davidturissini do you have any idea why the second usage?
from lwc.
I don't see any code that is referencing this API anymore in the global components. Is there any other blocker with removing this API?
from lwc.
from lwc.
let's remove it.
from lwc.
I'm hearing that @caridy is volunteering to remove occurrences in core! 🎉
from lwc.
there you go diego: #831
now we just need to wait 2 weeks to get this merged 🤣
from lwc.
Fixed by #831
from lwc.
Related Issues (20)
- Components that do not extend LightningElement should get dev warnings for missing `@api` HOT 3
- Components should not "inherit" `@api` from their superclasses HOT 1
- Add instrumentation/logging for native vs synthetic lifecycle callback differences HOT 1
- [ci] Firefox tests failing in SauceLabs
- DOMException: Failed to execute 'setAttributeNS' on 'Element' on `<svg xmlns:xlink>` HOT 3
- Unable to create hello world with LWC Open Source HOT 4
- Follow-up work for ElementInternals HOT 1
- `errorCallback` swallows SSR error HOT 2
- OpenTelemetry sdk for lwc HOT 4
- [3.7.0 regression] Re-rendering causes `this.refs.foo` to become `undefined` HOT 1
- [tests] `Unexpected attempt to set "disabled=true" property from the renderer`
- [Perf] Avoid calling `traverseAndSetElements` on every re-render
- [Template compiler] Event listeners on deep objects not being serialized properly HOT 2
- [Metadata] Inconsistency in AST for deep vs shallow expressions HOT 3
- Hydration does not support FACE or native lifecycle
- Simplify UpgradableConstructor use of native lifecycle callbacks
- Run Karma tests in CI in parallel
- Light Dom slots don't trigger `disconnectedCallback` in synthetic lifecycle HOT 3
- Inconsistent `disconnected/connectedCallback` behavior when duplicate `slot` name is used across `lwc:if`/`lwc:elseif`/`lwc:else` branches HOT 2
- Support ARIA element reflections on `BaseBridgeElement`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lwc.