Comments (5)
Hi,
I don't know what's happening. The theme files are present in the wheel and sdist on pypi.org, and it works for me locally when building the wheel from the .tar.gz. It also works when using the PKGBUILD
==> Making package: sigal 2.4-1 (Sat 30 Sep 2023 10:42:42 PM CEST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
-> Found sigal-2.4.tar.gz
==> Validating source files with sha512sums...
sigal-2.4.tar.gz ... Passed
==> Extracting sources...
-> Extracting sigal-2.4.tar.gz with bsdtar
==> Starting build()...
* Getting build dependencies for wheel...
/usr/lib/python3.11/site-packages/setuptools/config/pyprojecttoml.py:72: _BetaConfiguration: Support for `[tool.setuptools]` in `pyproject.toml` is still *beta*.
config = read_configuration(filepath, True, ignore_option_errors, dist)
validate_pyproject.api.load_builtin_plugin defines `tool.distutils` schema
validate_pyproject.api.load_builtin_plugin defines `tool.setuptools` schema
running egg_info
writing src/sigal.egg-info/PKG-INFO
writing dependency_links to src/sigal.egg-info/dependency_links.txt
writing entry points to src/sigal.egg-info/entry_points.txt
writing requirements to src/sigal.egg-info/requires.txt
writing top-level names to src/sigal.egg-info/top_level.txt
listing git files failed - pretending there aren't any
reading manifest file 'src/sigal.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'src/sigal.egg-info/SOURCES.txt'
...
One thing I changed since 2.3 is I removed the MANIFEST, since it's not needed when using setuptools-scm. However when building from the .tar.gz there is not git information, and I get a message in the build stage (above): listing git files failed - pretending there aren't any
, message that I cannot see in your log.
from sigal.
I'm building with SETUPTOOLS_SCM_PRETEND_VERSION=$pkgver python -m build --wheel --no-isolation
.
We are no longer relying on pypi sdist tarballs because they are not clearly defined and broken more often than not.
I think the issue is with the setuptools configuration (specifically https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages), which only finds simple packages. All the themes are not packages or namespaced packages though (they lack __init__.py
) and looking at https://setuptools.pypa.io/en/latest/userguide/datafiles.html#include-package-data I believe that the MANIFEST.in would still be required for that (otherwise the auto-generated source tarball can not be used).
It seems the more straight-forward way would be to use https://setuptools.pypa.io/en/latest/userguide/datafiles.html#package-data though (as it doesn't require MANIFEST.in).
from sigal.
I believe #503 to fix this issue
from sigal.
Hm, that appears to not yet fix it entirely.
There also seems to be at least one .js
file with sigal/plugins/encrypt/static/decrypt.js
that needs packaging as well. Will update the PR.
from sigal.
Okay, with #503 applied I can now build from the auto-generated tarball and all tests pass!
from sigal.
Related Issues (20)
- git main fails 31 tests HOT 3
- Encrypt plugin: Password field hidden behind pictures. HOT 2
- Using galleria theme causes empty whitespace in the base index page HOT 2
- Sigal not found HOT 2
- Problems with UTF8 characters on folders HOT 1
- 2.3: Issues with tests HOT 2
- Can't decrypt an encrypted gallery HOT 2
- tests fail with pillow release 10.0.0 HOT 8
- Some files have failed to be processed HOT 5
- KeyError: '.png'
- ImportError: cannot import name 'get_terminal_size' from 'click' HOT 3
- Album with hundreds of thumbnails crash Safari on iOS devices HOT 3
- Fatal error: This version of Galleria requires classic theme version 1.6 or later HOT 1
- Changes to the log level only affect the 'sigal' logger HOT 3
- Document sort order options HOT 3
- left/right arrows even when using a touchscreen HOT 1
- mode for updating a single (sub-)album HOT 1
- boto should be removed from optional dependencies HOT 1
- Demos don't resolve (DNS issue) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sigal.