Supporting secure websockets about sahb.graphqlclient HOT 11 CLOSED

I'll take a look at that route, and see if I can put together something acceptable. Will fire in a Pull Request if I get summat sorted.

from sahb.graphqlclient.

Hi, Think the best way would be to support a new static Default method on GraphQLSubscriptionWebSocketClient which support passing the ClientWebSocket as a parameter. I think this is what corresponds closest to the GraphQLHttpClient default method which support passing in a HttpClient.

Thanks for your suggestion :)

from sahb.graphqlclient.

Just having a look at this - I've forked the master, but when I open the solution it has loads of 'type or namespace name does not exist' errors. I don't want to mess about incorrectly with project settings etc - is there something more simple that I'm missing?

from sahb.graphqlclient.

Try installing Visual Studio 2019 with dotnet core. If it does not solve the problem try running the command "dotnet build" and send the errors to me.

Thanks for your help with improving the client! :)

from sahb.graphqlclient.

I'm using 2019 (with preview SDK enabled).
Tried a 'dotnet build' - in the sln directory - doesn't give errors which appear to relate to the VS issues, but does complain about Version.props being missing. So I've removed the include from Common.props, and 'dotnet build' then seems to work.
And VS is now able to parse/understand everything..... who'd have thought that would have thrown up a load of 'does not exist' errors in VS Intellisense!
(Now just need to figure out how to set '_websocket' (if that's the correct approach?) from a static "Default" func...)

from sahb.graphqlclient.

I guess you generate Version.props as a scripted pre-build step?

from sahb.graphqlclient.

Ah okay. Yes thats correct - please see the steps which is required here:
https://github.com/sahb1239/SAHB.GraphQLClient/blob/develop/appveyor.yml

I Will update the readme

from sahb.graphqlclient.

You could create a new static Default method which could call a new constructor which takes the websocket as a input parameter. I think that would be a good way to do it.

from sahb.graphqlclient.

You could create a new static Default method which could call a new constructor which takes the websocket as a input parameter. I think that would be a good way to do it.

Ah, an additional GraphQLSubscriptionWebSocketClient constructor, coupled with an additional static IGraphQLSubscriptionWebSocketClient Default() ?

from sahb.graphqlclient.

Yep that would solve the problem assigning to the readonly variable

from sahb.graphqlclient.

This should now be fixed by #72

from sahb.graphqlclient.