Comments (7)
It is fine. I have given it much thought and looked at plenty of style guides and examples regarding namespacing so this is not too uncommon. Since I am no longer using ngAnnotate I have to inline annotate anyway.
Anything prefixed with satellizer.
is not meant to be extendable or overridable, it is for internal usage only. Once AngularJS 2.0 comes around I will make all those services private.
from satellizer.
Alright, as always I respect your decisions, I just point out things that are more weird. I never saw that namespacing tbh and I done a lot of angular so far.
Leave it as is then, if it is not mean to be decorated by end users, good enough :)
from satellizer.
You might be right, I may have confused it with module namespacing notation, which is very common. Either way it's just an internal implementation detail.
We can discuss whether to keep it or switch to camelCase later, after all primary issues are fixed.
from satellizer.
Yes, module notation is different, but yes, let's talk about that after things are fixed.
from satellizer.
@Foxandxss If I namespace each service into its own module called satellizer.popup
for example, and then require it in the main satellizer module like so:
angular.module('satellizer', ['satellizer.popup']);
Will satellizer.popup
module be private if someone includes the main satellizer module in their app?
angular.module('MyApp', ['ngResource', 'ngMessages', 'ngRoute', 'satellizer', 'mgcrea.ngStrap'])
from satellizer.
no, it will be "public", so i can use it like:
angular.module('foo', ['satellizer.popup'])
can't really see how that causes an issue, tho :-)
from satellizer.
The thing is, why you need private? You don't. People will still inject "satellizer" to use the library, but if they need to inject the other inner services for something, let them do it!, You shouldn't restrict what they can do.
from satellizer.
Related Issues (20)
- Custom parameters in `*UrlParams`
- Twitter API Not working
- Auth full screen instead of popup
- Redirecting SPA
- Twitter API gives an error "Callback URL not approved for this client application" HOT 3
- Please hand this over to someone who can and willing to maintain this HOT 3
- Popup not closing in Firefox HOT 1
- Native Facebook login
- TypeError: Cannot read property 'oauthType' of undefined
- support of the angularjs version 1.3.x
- Google+ API Shutdown HOT 1
- state token
- popup not closing at /callback url HOT 1
- Login with Google OAuth2 Workflow Question HOT 1
- LinkedIn scope parameter problem HOT 4
- Regarding callbackurl for twitter
- Instagram Redirect URI Issue on Cordova
- When I load my website the word "#hello" comes first Opencart website
- redirect_uri Error on Anroid Devices using Satellizer/Angularjs/Cordova
- TiktTok Login compatibility using satellizer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from satellizer.