Bug: removing after Facebook login: #_=_ about hackathon-starter HOT 3 CLOSED

There is a whole discussion on this issue: http://stackoverflow.com/questions/7131909/facebook-callback-appends-to-return-url

Most of the solutions involve manual URL cleanup via JavaScript. E.g.

if (window.location.hash == '#_=_') {
    window.location.hash = ''; // for older browsers, leaves a # behind
    history.pushState('', document.title, window.location.pathname); // nice and clean
    e.preventDefault(); // no page reload
}

In other words it's the Facebook's fault. But they apparently have a good reason for doing that: https://developers.facebook.com/x/bugs/318390728250352/

Now, the reason why I don't want to add that JavaScript code to cleanup the hash URL is to avoid putting non-application logic inside main.js. Since this is a boilerplate project I want to keep client-side javascript file to be clean and simple, instead of fixing other's shortcomings:

$(document).ready(function() {

  // Place JavaScript code here...

});

And as much as I'd like to add lots of client-side code to make this boilerplate even more impressive, doing so will only confuse other developers. But you do have an option of adding the above mention JS code yourself, to clean up the URL hash manually, if it bothers you.

from hackathon-starter.

I'd like to offer an alternative viewpoint. I think this is exactly the type of thing to include in a boilerplate framework (along with good comments/documentation about why it's there).

Why?

Because otherwise assuming all 4000+ people who starred this project actually use the framework someday they all have to independently figure out this quirk of facebook's and fix it. I don't want to have to search Stack Overflow.

I LOVE it when boilerplate frameworks deal with quirks like this so I can just focus on building stuff. Heck - why did jQuery and Bootstrap become popular in the first place? Because they dealt with all the cross-browser crap. ;)

from hackathon-starter.

I agree with @sahat.

Some people won't use Facebook connect, so if we add it to main.js, we might cause more confusion. And to echo Sahat, it's Facebook's fault so we shouldn't write glue code for them; they could later decide to fix it.

The best solution is to provide a link to S.O. in the README under the Facebook section. Submitting a PR...

from hackathon-starter.