Code Monkey home page Code Monkey logo

Comments (6)

oronnavon avatar oronnavon commented on July 28, 2024 1

@sxmichael So it seems to me we can afford to skip .NET Core 1.1 support. Would appreciate if you would give it a shot adding .NET Core 2.0 support.

from cardinalityestimation.

oronnavon avatar oronnavon commented on July 28, 2024

Probably no serious reason. I have zero experience with .NET Core but I'd wager it's just a matter of compiling our dependency murmurhash with .NET Core and publishing to NuGet. I'll contact the owner @darrenkopp and ask.

from cardinalityestimation.

darrenkopp avatar darrenkopp commented on July 28, 2024

hey @sxmichael i just pushed a new version of the package which targets .net standard 1.4. let me know if that doesn't work for you and i can look further into targeting something lower.

from cardinalityestimation.

sxmichael avatar sxmichael commented on July 28, 2024

@darrenkopp thanks a lot! Now murmurhash nuget package is .net core compatible.

@oronnavon I tried to create a project for .net core for CardinalityEstimation and compile manually. After murmurhash package was updated, one thing which was missing is System.Runtime.Serialization.Primitives nuget package (in .net core System.Runtime.Serialization was moved to separate lib: dotnet/docs#319).
After this only two errors left:

The type or namespace name 'SerializableAttribute' could not be found (are you missing a using directive or an assembly reference?)
The type or namespace name 'NonSerializedAttribute' could not be found (are you missing a using directive or an assembly reference?)

Both attributes are used on CardinalityEstimator class. It seems like those are needed for BinaryFormatter, which is not supported in .net core, at least till version 2.0: https://github.com/dotnet/coreclr/issues/1203

from cardinalityestimation.

saguiitay avatar saguiitay commented on July 28, 2024

@sxmichael I've just merged #22 which should add support for .Net Core 2.0

from cardinalityestimation.

saguiitay avatar saguiitay commented on July 28, 2024

Version 1.7 is now publicly available in NuGet.Org: https://www.nuget.org/packages/CardinalityEstimation/

from cardinalityestimation.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.