4.3.0: pytest is failing in `tests/test_all.py::DNSTest::test_custom_resolvconf` unit about pycares HOT 5 OPEN

• build is performed in env which is cut off from access to the public network (pytest is executed with -m "not network")

Then a number of the tests will simply fail. The test suite creates real DNS traffic.

from pycares.

• build is performed in env which is cut off from access to the public network (pytest is executed with -m "not network")

Then a number of the tests will simply fail. The test suite creates real DNS traffic.

So it would be good to @pytest.mark.network to those units which requires such access.
https://docs.pytest.org/en/7.1.x/example/markers.html
network mark is already quite widely used in many other python modules test suites.

from pycares.

The test suite does not use pytest, it currently uses the vanilla unittest module.

I'd take a PR improving things here, but as it stands if you are interested in running the tests you need Internet access.

from pycares.

Correctly written unittest test suite can be handled by pytest.
Any units which needs public network should have @pytest.mark.network https://docs.pytest.org/en/7.1.x/example/markers.html as that mark is currently widely used by many other python modules test suites.

from pycares.

PRs are welcome. I currently don't have the time or energy to see if pytest would just work and add decorate functions.

If you'd like to send a PR I'd be happy to review it.

from pycares.