Hi, I am using this package with Django 3, and I have noticed that doing <code cla

I believe that <a class="issue-link js-issue-link" data-error-text="Failed to load tit

Closed by <a class="issue-link js-issue-link" data-error-text="Failed to load title" d

I noticed the same thing as <a class="user-mention notranslate" data-hovercard-type="u

Migrations problems with Django 3 about django-webpush HOT 5 CLOSED

Trafitto commented on June 11, 2024

Migrations problems with Django 3

from django-webpush.

Comments (5)

satoon101 commented on June 11, 2024 1

Actually, looking at this stack overflow answer, you should be able to add an apps.py and make a default there.

from django-webpush.

satoon101 commented on June 11, 2024 1

I believe that #122 should fix this issue for everyone going forward.

from django-webpush.

safwanrahman commented on June 11, 2024

Closed by #111

from django-webpush.

tyilo commented on June 11, 2024

After this fix and running ./manage.py makemigrations Django generates the following migration in my project:

# Generated by Django 3.2.16 on 2022-11-22 20:21

from django.db import migrations, models


class Migration(migrations.Migration):

    dependencies = [
        ('webpush', '0004_auto_20220831_1500'),
    ]

    operations = [
        migrations.AlterField(
            model_name='group',
            name='id',
            field=models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID'),
        ),
        migrations.AlterField(
            model_name='pushinformation',
            name='id',
            field=models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID'),
        ),
        migrations.AlterField(
            model_name='subscriptioninfo',
            name='id',
            field=models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID'),
        ),
    ]

I think it was a mistake to change the fields to BigAutoField as done in the pull request.

from django-webpush.

satoon101 commented on June 11, 2024

I noticed the same thing as @tyilo. Instead of using BigAutoField, it should respect the app's DEFAULT_AUTO_FIELD setting. The whole reason that @Trafitto had to create a migration in the first place is likely because they were using BigAutoField as the DEFAULT_AUTO_FIELD.

from django-webpush.

Recommend Projects