Comments (1)
rmeissner
commented on July 22, 2024
Hey @GuthL
this is very interesting, but doesn't meet all our requirements. Since we are trying to enable every user to have a contract base wallet, it should be possible that contract based wallets can be owners of other contract based wallets. This is not possible with distributed private keys.
Also distributed private keys / signing are not as flexible when it comes to adding/ removing owners. All this is defined when creating the set of secrets (at least afaik).
It should still be possible to already make use of this with the current contracts (just create a Safe with 1 owner and threshold 1). The additional gas costs for the loop are very low. The only big difference is when creating the safe, as it would be possible to only store 1 variable (the owner) which would safe around 50k gas (1 time).
I will close this issue, since we will not change our contracts.
from safe-smart-account.
Related Issues (20)
- Extend Safe With Additional Signing Schemes HOT 2
- Add an `ISafe` Interface For Interacting with Safes
- Bug report
- ,
- [Safe 1.5.0] Evaluate Posibility of moving `checkSignatures(bytes32, bytes, bytes)` into `Safe` HOT 3
- [Safe 1.5.0] `execTransactionFromModuleReturnData` Will Return Guard `returndata` HOT 3
- Provide developer utils for foundry
- Fallback function could be made payable.
- Evaluate strategies for reducing Safe code size
- Provide a way to identify whether a contract is a SAFE. HOT 1
- Expose revert message when internal transaction fails and `safeTxGas`/`gasPrice` are 0
- ProviderError: not enough gas supplied for intrinsic gas costs HOT 2
- Rename the repo to `safe-smart-account` HOT 5
- Technical background for `onlyNonceZero` in `SafeToL2Migration`? HOT 6
- JSON Mix Up
- Figure out why Safe can't compile on 0.8 with IR optimizations HOT 2
- Imports Ordering for Contracts HOT 2
- Using `returndatasize()` directly in assembly HOT 1
- Compilation fails with solc 0.8.23 HOT 4
- LZ's `sendFrom()` produces insufficient gas error in tx simulation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safe-smart-account.