Add tests for ERC20 transfer about safe-smart-account HOT 15 CLOSED

Hey @owocki please do that :) Maybe it makes sense if I add some detais to the issue beforehand (e.g. acceptance criteria and some more details about the use cases). I can do this tomorrow. Would this work?

from safe-smart-account.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $20,901.36 more funded OSS Work available on the Gitcoin Issue Explorer

from safe-smart-account.

@rmeissner let me know if/when to payout :)

from safe-smart-account.

@rmeissner hi from gitcoin.co... we have some budget to place on small issues like this. do you mind if i post a bounty of like 100 DAI on this?

from safe-smart-account.

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from safe-smart-account.

@rmeissner I would like to tackle this.
One question Should i write tests for the ERC20 mock implementation ?

I have applied on gitcoin as well

from safe-smart-account.

@subramanianv that should not be necessary as long as the mock implementation is kept to a minimum. It is also only necessary that the mock token implements the methods used for the tests (so if transferFrom is not used, no need to implement it ;) )

EDIT: this is the token we use right now for testing: https://github.com/gnosis/safe-contracts/blob/development/test/utilsPersonalSafe.js#L87

from safe-smart-account.

@rmeissner I have made a early PR just to know if I am on the right track. There is a test case should fail if token payment fails under gnosisSafePersonalEditionCreation.js. In that how would you estimate userCosts. it has been hardcoded to 1337. Please review this PR.

from safe-smart-account.

@rmeissner I am now using the mock contract npm module. However there is one test that I am expecting to fail but it doesn't. Can you take a look ?

        let mockToken = MockToken.at(mockContract.address);
        let transferData = await mockToken.contract.transfer.getData(executor, 91861);
        await mockContract.givenRevert(transferData);
        await web3.eth.sendTransaction({from: accounts[0], to: gnosisSafe.address, value: web3.toWei(1.1, 'ether')})
        let tx = await safeUtils.executeTransaction(lw, gnosisSafe, 'executeTransaction withdraw 0.5 ETH', [lw.accounts[0], lw.accounts[2]], accounts[0], web3.toWei(0.5, 'ether'), "0x", CALL, executor, { gasToken: mockToken.address })```

from safe-smart-account.

@rmeissner I am using the new mockContract. Please review the PR and let me know if I need to add more tests. Thanks :)

from safe-smart-account.

@owocki I am trying to submit work for this task on gitcoin website. Metamask throws an error ALERT: Transaction Error. Exception thrown in contract code. Can you help ? Thanks.

from safe-smart-account.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

1. @subramanianv

@owocki please take a look at the submitted work:

• PR by @subramanianv

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $19,317.30 more funded OSS Work available on the Gitcoin Issue Explorer

from safe-smart-account.

@owocki All requested tests have been implemented and the PR has been merged :) So I am fine with the payout ;)

from safe-smart-account.

@owocki Can you process the payout when you get a chance ? Thank you :)

from safe-smart-account.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @subramanianv.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $25,742.25 more funded OSS Work available on the Gitcoin Issue Explorer

from safe-smart-account.