Comments (4)
rmeissner
commented on June 23, 2024
I implemented this on https://github.com/gnosis/safe-contracts/tree/feature/improve_team_edition
I was asking myself if it would make more sense to provide a clearApproval. Mainly because if by any change the required gas changes and the transaction fails because of not enough gas, all confirmations have to be gathered again.
from safe-smart-account.
Georgi87
commented on June 23, 2024
Who should be allowed to call clearApproval? This would require another multisig tx?
from safe-smart-account.
rmeissner
commented on June 23, 2024
@Georgi87 it would be more that each owner can clear his own approval (actually it shouldn't be required to be an owner to clear your approval, so that you can remove your approval even after you are not an owner anymore)
from safe-smart-account.
rmeissner
commented on June 23, 2024
Close because of #53
from safe-smart-account.
Related Issues (20)
- ,
- [Safe 1.5.0] Evaluate Posibility of moving `checkSignatures(bytes32, bytes, bytes)` into `Safe` HOT 3
- [Safe 1.5.0] `execTransactionFromModuleReturnData` Will Return Guard `returndata` HOT 3
- Provide developer utils for foundry
- Fallback function could be made payable.
- Evaluate strategies for reducing Safe code size
- Provide a way to identify whether a contract is a SAFE. HOT 1
- Expose revert message when internal transaction fails and `safeTxGas`/`gasPrice` are 0
- ProviderError: not enough gas supplied for intrinsic gas costs HOT 2
- Rename the repo to `safe-smart-account` HOT 5
- Technical background for `onlyNonceZero` in `SafeToL2Migration`? HOT 6
- JSON Mix Up
- Figure out why Safe can't compile on 0.8 with IR optimizations HOT 2
- Imports Ordering for Contracts HOT 2
- Using `returndatasize()` directly in assembly HOT 1
- Compilation fails with solc 0.8.23 HOT 4
- LZ's `sendFrom()` produces insufficient gas error in tx simulation HOT 1
- zksync branch doesn't seem to contain correct zksync deployment scripts
- Signature verification does not enforce a maximum size on the signature bytes
- Split Guard into Module and Transaction Guard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safe-smart-account.