Code Monkey home page Code Monkey logo

Comments (4)

s-yadav avatar s-yadav commented on August 25, 2024

@AakashGfude Having Id is not required. And also this.temporaryElement.querySelector('.react-head-temp') will always be available.
Can you share code sample with which I can reproduce this. Also it will be great if you can setup a codesandbox which has this error. It will be easier for me to debug.

from react-meta-tags.

AakashGfude avatar AakashGfude commented on August 25, 2024

My code for metatag is the minimal one :-

`class MetaTag extends Component {

     render() {
        return (
           <div>
              <MetaTags>
                  <title>{this.props.title}</title>
                  <meta name="description" content={this.props.description} />
                  <meta property="og:title" content={this.props.title} />
                  <meta property="og:description" content={this.props.description} />
             </MetaTags>
           </div>
       )
    }
 }`

The situation arises, when I update the description tag, which is done by editing the summary of an article. The summary of the article is sent as a description tag to metaTags component.
I will try to replicate the scenario, but it might be difficult as there are a lot of mounting and unmounting of components involved.
Can you give me a heads up of what this class 'react-head-temp' is , or any other tips.

Thanks

from react-meta-tags.

UwUnyaa avatar UwUnyaa commented on August 25, 2024

I'm getting this exact error, and it seems that react-meta-tags just doesn't test whether Element.querySelector() returns a DOM node or null, and crashes in the latter case. I can provide a PR if needed.

from react-meta-tags.

UwUnyaa avatar UwUnyaa commented on August 25, 2024

I provided a PR with the fix here: #29

from react-meta-tags.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.