Code Monkey home page Code Monkey logo

Comments (3)

bodil avatar bodil commented on September 4, 2024

Makes a lot of sense to me. I'd maybe even just throw out the backwards compat stuff, as long as it breaks with a helpful error message on how to upgrade. Seems like such a minor change it's not worth keeping edge cases around in the codebase for.

from lein-npm.

radhikalism avatar radhikalism commented on September 4, 2024

A few notes:

  • I support this change.
  • We tried to do a similar thing with lein-bower, by grouping settings under :bower.
  • However, lein-bower depends on lein-npm for dependency resolution, so I think because of the assumption that :node-dependencies would be at the top level, :bower-dependencies also had to stay.
  • So I'd suggest either retain backwards-compatibility to allow lein-bower to gracefully catch up, or try to commit and release both roughly synchronously.

from lein-npm.

RyanMcG avatar RyanMcG commented on September 4, 2024

@arbscht I believe lein-bower uses resolve-node-deps. I think I'll modify it so it uses lookup-key as a function (i.e. (lookup-key project) instead of (project lookup-key)). That will be backwards compatible and the new lookup function will be easy ((comp :dependencies :npm)).

@bodil The issue with not being backwards compatible is that we use the same lookup function to lookup npm dependencies in jar and checkout dependencies and clients may not be able to control the project definitions of their dependencies..

from lein-npm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.