Comments (3)
Makes a lot of sense to me. I'd maybe even just throw out the backwards compat stuff, as long as it breaks with a helpful error message on how to upgrade. Seems like such a minor change it's not worth keeping edge cases around in the codebase for.
from lein-npm.
A few notes:
- I support this change.
- We tried to do a similar thing with lein-bower, by grouping settings under
:bower
. - However, lein-bower depends on lein-npm for dependency resolution, so I think because of the assumption that
:node-dependencies
would be at the top level,:bower-dependencies
also had to stay. - So I'd suggest either retain backwards-compatibility to allow lein-bower to gracefully catch up, or try to commit and release both roughly synchronously.
from lein-npm.
@arbscht I believe lein-bower uses resolve-node-deps
. I think I'll modify it so it uses lookup-key as a function (i.e. (lookup-key project)
instead of (project lookup-key)
). That will be backwards compatible and the new lookup function will be easy ((comp :dependencies :npm)
).
@bodil The issue with not being backwards compatible is that we use the same lookup function to lookup npm dependencies in jar and checkout dependencies and clients may not be able to control the project definitions of their dependencies..
from lein-npm.
Related Issues (20)
- How to add `npm prune` in a hook before installing? HOT 6
- Order packages by name HOT 12
- Respect existing package.json? HOT 5
- Add the capability to dump the generated package file HOT 1
- npm-root must exist HOT 1
- Install npm dependencies automatically HOT 9
- No packages installed with 0.6.1 HOT 3
- Show progress when installing HOT 2
- error when installing a github dependency HOT 4
- Dev dependencies should be specified the same way Production dependencies are HOT 1
- Allow packages to be published
- Don't install NPM modules from my apps dependencies HOT 2
- Wierd error when importing @blueprintjs/core HOT 4
- Missing script HOT 1
- How to import modules in Clojurescript ? HOT 1
- Only picks up transitive deps from libraries snapshot builds HOT 1
- Does not pick up transitive dependencies on Leiningen 2.8.1
- How To Require Packages Added With lein-npm? HOT 2
- Hooks are deprecated HOT 1
- Publishing new release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lein-npm.