Code Monkey home page Code Monkey logo

Comments (11)

ryanheise avatar ryanheise commented on July 21, 2024

Hi @ened , thanks for the report. I will look into it.

from audio_session.

ryanheise avatar ryanheise commented on July 21, 2024

Can you try the latest commit? Tracing the logic that could cause this, I would guess your app has at least 2 FlutterEngines/isolates, and the second one was shutdown, followed by a loss of audio focus. The other possibility (which doesn't seem to be the case here) is that the first isolate was shut down. The latest commit should hopefully handle both situations, although since I wasn't actually able to reproduce the error, hopefully you can try it out and let me know how it goes.

from audio_session.

ened avatar ened commented on July 21, 2024

2 isolates, correct - either of which can be stopped at any time and started at any time (Android Activity + Foreground Service).
This is happening in our production App - appreciate if you can cut a new release for this.

from audio_session.

ryanheise avatar ryanheise commented on July 21, 2024

Just to confirm, did the latest commit work for you?

from audio_session.

ryanheise avatar ryanheise commented on July 21, 2024

Note that I would normally want to do more testing before publishing a new release with a substantial change to the logic like this. However, if you are happy with that commit, I would recommend until then that you pin your app to that specific commit as follows:

dependencies:
  audio_session:
    git:
      url: https://github.com/ryanheise/audio_session.git
      ref: e40d76dcda985fea4a42c06839f30f37af1c7781

(You may need dependency_overrides if you are also using other plugins that use audio_session such as audio_service or just_audio.)

from audio_session.

ened avatar ened commented on July 21, 2024

@ryanheise looks good - thank you for your help. I've tested this on our app locally and did not observe any crashes.

from audio_session.

ryanheise avatar ryanheise commented on July 21, 2024

Great! I'll probably do the next release this coming weekend. If you encounter any further issues during that time, let me know and I'll try to address them before the release.

from audio_session.

ened avatar ened commented on July 21, 2024

@ryanheise Hi are you still planning a release?

from audio_session.

ryanheise avatar ryanheise commented on July 21, 2024

Sure, I can do that now; I assume you didn't run into any further crashes with this commit?

from audio_session.

ened avatar ened commented on July 21, 2024

Yes looks good so far. We will pass the release candidate to our testers this week - will report if more issues are found.

from audio_session.

ryanheise avatar ryanheise commented on July 21, 2024

Thanks, I also haven't run into any issues on my end so I've published 0.0.11.

I'll close this for now but if you do run into further issues, do let me know and I will reopen.

from audio_session.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.