Code Monkey home page Code Monkey logo

Comments (5)

MatthewSteel avatar MatthewSteel commented on July 22, 2024

Would it be against the philosophy of this project to extend range iterators with the operations required of random access iterators? (operator+, operator< etc)?

It would be nice to get log time std::lower_bound with this library, and it's technically feasible. I can send a PR if it would be welcome.

from cppitertools.

ryanhaining avatar ryanhaining commented on July 22, 2024

There are aspects of random access iterators that can't be easily handled by range, since there isn't an underlying sequence to point to. Even having it as a ForwardIterator is sort of lying. This is not to say that you couldn't go about implementing some of the operators, but standard libraries will still use the iterator category to figure it out, and you can't update the category without implementing all of the required functions.

Look at libc++'s implementation of std::lower_bound which calls through to std::advance, which of course is implemented using tag dispatch on the iterator_category.

I've thought about reaching for more advanced iterator tags before with range, I think bidirectional is doable, but the situation is more complicated with random access.

All that said, if you would like to look for a path forward I'm happy to talk or review PRs.

from cppitertools.

MatthewSteel avatar MatthewSteel commented on July 22, 2024

Hmm, I think the only real difficulty (though it may be insurmountable) is that the dereference operations are meant to return references, not values. All of the other operations look pretty simple.

Subclassing the trait tag with that imperfection is probably a dreadful idea, though, so I'll go another few years without a lightweight, well-maintained way to binary search over integers :-/.

Thanks for the help finding the flaw in that plan.

from cppitertools.

ryanhaining avatar ryanhaining commented on July 22, 2024

from cppitertools.

MatthewSteel avatar MatthewSteel commented on July 22, 2024

I wouldnt know sorry, I was just voicing a vague hope that enough people will reinvent the wheel that one of them will turn out to be useful.

from cppitertools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.