zip.hpp doesn't compile with gcc 8.2.1 about cppitertools HOT 8 CLOSED

confirmed, repro with 8.2.0

from cppitertools.

const iterators need to compare with non-const iterators, if you cd into test/ and run scons test_zip you'll see a ton of errors without the friend declaration. We want all Zip<Ts...>::Iterator<...> implementations to be friends with each other

from cppitertools.

from cppitertools.

Btw, the stuff we are using works fine when I comment out this friend deceleration.
Can you explain why it is there?

from cppitertools.

still trying to see if I can shrink this but here's a repro case:

template <typename>
struct Outer {
  template <template <typename> class>
  class Failure {
    template <template <typename> class>
    friend class Failure;
  };

  using F = Failure<Cls>;
};

int main() {
  Outer<void>::F var;
}

Failing with

• gcc-8.1.0
• gcc-8.2.0
• gcc HEAD 9.0.0 20181017

but passes with gcc-7.3.0

I'll file a bug against gcc 8

from cppitertools.

Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87651

not sure if I can provide any fix other than making the iterator data members public :/

from cppitertools.

and a similar bug breaking filter. gcc really slipped up on 8 I guess https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87652

from cppitertools.

Is this fixed in master now?

from cppitertools.