Code Monkey home page Code Monkey logo

Comments (4)

ryanhaining avatar ryanhaining commented on June 24, 2024

All of the itertools have InputIterators for the sake of it being doable. You can't reverse something with input iterators without constructing a temporary container to hold the contents, but then you lose the lazy evaluation.
Supporting reverse would mean supporting types that may have rend() and rbegin() themselves, or only extending the iterator capabilities in the case of the underlying sequence (container1, etc) having a more flexible iterator type. The work involved here is huge, I don't have any plans to implement this right now.
If your two containers are of equal length and are themselves reversible, I think you could get away with

zip(reversed(container1), reversed(container2))

from cppitertools.

ptenbrock avatar ptenbrock commented on June 24, 2024

Thank you for your quick answer! The code you proposed works in my situation.

I will have a look if I can find a general solution involving rend() and rbegin() but I have little experience in heavy template usage.

from cppitertools.

ryanhaining avatar ryanhaining commented on June 24, 2024

it's pretty heavy. The SFINAEing involved will need to be pretty precise if I'm picturing this correctly. Reversing is also non-obvious for many itertools. For example, consider the case where container1 and container2 have different lengths:

std::vector<int> v = {1, 2, 3};
std::string s{"abcdef"};

If you zip this zip(v, s) you'll get

{1, a}
{2, b}
{3, c}

If you reverse it reversed(zip(v,s)), what should you get? The reversed version of the above would be

{3, c}
{2, b}
{1, a}

but that doesn't match zip(reversed(v), reversed(s)):

{3, f}
{2, e}
{1, d}

from cppitertools.

ptenbrock avatar ptenbrock commented on June 24, 2024

I think in case of containers of different length it would be ok if the two versions with reversed() differ, as long as the rules of how they work/differ are clear.

I realized I won't have the time to work on an implementation right now and my problem has been solved, so I will close this issue. Thanks for your help!

from cppitertools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.