Comments (4)
@TobiasRe please make an issue or talk about the memory issues
from rxflow.
Thanks @twittemb
Yes the CompositeStepper
helps, if I including navigation to the corresponding sub flows in my MainFlow
.
The issue that remains is how to handle deep linking on app start. Especially if the app needs some kind of bootstrapping/login before the app is ready to handle the deep link.
I guess the best to create an Observable
where the deep link step is queued until the app is ready.
let deepLinkObservable = deepLinkSteps.sample(mainStepper.steps.filter{$0 == AppSteps.ready})
deepLinkObsersavable.subscribe(onNext: {step in
deepLinkStepper.accept(step)
}).disposed(by: disposeBag)
or similar.
from rxflow.
This feature is currently on hold for me.
There are serious memory management issues with RxFlow to fix first.
I can create a PR when the Deeplink Stepper
implementation is done.
Let's close this for now.
from rxflow.
Hi @TobiasRe
Thanks for your feedback.
I think you could use the new "CompositeStepper" feature. In your AppDelegate you could something like that (adapt to your case of course)
let deepLinkStepper = DeepLinkStepper()
let mainStepper = CompositeStepper(steppers: [OneStepper(withSingleStep: DemoStep.apiKey), deepLinkStepper])
coordinator.coordinate(flow: mainFlow, withStepper: mainStepper)
DeepLinkStepper should be a custom Stepper that you have to write (just implement the Stepper protocol).
You will trigger your instance of deepLinkStepper when a notification is received (DeepLinkStepper can have a function per notification type for instance). As it is associated to the MainFlow, Steps triggered by the DeepLinkStepper will be catched in that flow and you just have to implement the navigation in the switch statement of the navigate(to:) function.
Does it fit with your needs ?
from rxflow.
Related Issues (20)
- Child view controller steps HOT 5
- Please document memory management HOT 4
- CompositeStepper not calling InnerSteppers readyToEmitSteps HOT 4
- Block links are invalid HOT 1
- Something strange happening in ios14 HOT 3
- unknown dependency 'RxCocoa' in target 'RxFlow' HOT 6
- `Reactive+UIViewController`'s `dismissed` event is retaining the view controller HOT 2
- Question regarding intended behavior of FlowCoordinator's navigate(to:) function HOT 4
- Flow.rxVisible never emits `true` event when pushing view controller without animations HOT 3
- Coordinator navigate(to: ) does not override initialStep HOT 10
- How to handle opening multiple flows upon clicking a deeplink HOT 3
- Adapt step in the background causes `navigate` to be called on the same thread HOT 6
- Reentrancy anomaly on .forwardToCurrentFlow HOT 9
- Cannot step in child flow after using .multiple with .forwardToCurrentFlow, and others. HOT 1
- How to handle searchResultsController
- Child controllers are never deallocated HOT 5
- Adapt method is disposed before being completed HOT 1
- displayed is incorrect if subscription occurs when view is already on screen HOT 1
- Seeking a new maintainer HOT 8
- Initiating a step from a completion inside of a sink for Future Published (Combine) HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rxflow.