Search issue:- An observation about bicbucstriim HOT 7 CLOSED

I think it can be done by adding rtrim( ) function when searching for something.
This will remove the space at the end.

At line 569 - file: index.php

if (isset($search)) {
    $search = rtrim($search); // this should remove it. I haven't tested it out.
    $app->getLog()->debug("titlesSlice: search=".$search);
    $tl = $bbs->titlesSlice($index,$globalSettings[PAGE_SIZE],$search);

from bicbucstriim.

Yes, you both are right. Trimming would help there. I'll add a trim to searches, so that both leading and trailing whitespace will be removed.

from bicbucstriim.

blowk, thank you. I've edited index.php as you have written it above. It failed to truncate my search term white space. Probably me doing something wrong though.

rvolz, much appreciated. I wouldn't call it a bug though. Just a user using autocomplete. Thanks for acknowledging.

from bicbucstriim.

Ok, then we make it an enhancement. If you need the feature urgently change line 571 in index.php from

$tl = $bbs->titlesSlice($index,$globalSettings[PAGE_SIZE],$search);

to

$tl = $bbs->titlesSlice($index,$globalSettings[PAGE_SIZE],trim($search));

That removes leading and trailing whitespace for me. Please note, that this would only change the book search. If you want more you would have to repeat the process for functions authorsSlice, tagsSlice and seriesSlice.

from bicbucstriim.

blowk, it was me doing something wrong. I edited the right line but tested incorrectly. Oh well, as I get older, my brain gets smaller.And thank you.

rvolz, Wow. What a gentleman you are also. I've edited titles, authors, tags and series (surprisingly easy to copy and paste - even for me) I've tested it on tags. It works great.

Many, many thanks to you, rvolz and blowk.

from bicbucstriim.

@Baldbloke, @blowk thx for testing this. I'll add the change to the repo soon.

from bicbucstriim.

no problem

from bicbucstriim.