Comments (2)
FishHooks
commented on May 29, 2024
@brianjmiller would it make sense to try constructing a TinCan.Statement object from the object passed, or should we be strict on this and only accept TinCan.Statement objects?
from tincanjs.
brianjmiller
commented on May 29, 2024
Actually I now suspect this is because of the dumb default of allowFail. Unfortunately didn't record how the TinCan.LRS object was constructed, but it makes sense that there wouldn't be an error in the callback if allowFail is set to true (which is the dumb default, one of the items on the roadmap #110). Though in this case perhaps even for allowFail set to true we could fail because it isn't the communication with the LRS that is failing, it is an improper use of the library.
I've thought about auto-constructing a statement object, but I don't know that there is a reason to change it for this issue, the larger problem was that even in that case it should still fail.
from tincanjs.
Related Issues (20)
- LRS invalid: failed to divide URL parts HOT 5
- disregard
- LRS.queryStatements drops more link for multipart response?
- `LRS.moreStatements` doesn't handle multipart responses
- StatementsResult object should handle `more: ""` like `null`
- Return value from Statement() is not a valid xAPI statement HOT 3
- Need access to original statement from HTTP response HOT 3
- Unity with TinCan API Version Question HOT 4
- Exclude cryptoJs to build for include in dependancy.
- Catch error when neither auth or username and password LRS properties are set
- Paging does not work with attachments
- Future plans with this project? HOT 2
- How to load activity_id from query string instead of config HOT 3
- agent block causes an error if it doesn't contain an "mbox" key/value pair HOT 3
- Typscript type definitions? HOT 3
- How to saveAgentProfile? HOT 1
- error while installing in nodejs HOT 1
- How best to defeat browser caching when requesting Activity Profile HOT 2
- What is the difference between this and the official xApiWrapper?
- Using TinCanJS in my application
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tincanjs.