Comments (5)
Let me try. look_at
doesn't really need the values directly, it just performs calculations based on the vectors you provide. Frustum::new
on the other hand uses the given set of planes directly to store it. I do realize, however, that this is an implementation detail, so maybe we shouldn't reflect that in the interface.
from cgmath.
Ok, so your general preference is to pass in stuff by reference to avoid copies then? I might be contributing with other minor pieces of code these days, so I'm trying to understand your coding guidelines. This is also my third day of Rust, so I am also using your library as a source of inspiration :)
from cgmath.
Yes, that was my impression. I'm not the best person to answer that though, so please wait for @bjz to get here.
from cgmath.
For constructors I normally go by value, but for methods by ref. This may or may not be the best way... I dunno.
from cgmath.
We are now moving to a by-value style - see #247
from cgmath.
Related Issues (20)
- Why does `Point` exist? HOT 8
- Project management HOT 1
- Angle trait + Sized HOT 2
- Rotation matrix handedness HOT 2
- No Basis3 or Matrix3 identity? HOT 3
- Changelog not updated for v0.18 HOT 1
- Formatting of code in documentation of conv is broken HOT 1
- Creating a Matrix4 from Quaternions HOT 2
- "mint" feature not mentioned in the doc or anywhere HOT 1
- look_at for model matrices? HOT 2
- Unspecified behavior in `impl_tuple_conversions` HOT 2
- println!("{:?}", Vector3) gives wrong values?! HOT 1
- Help converting `Matrix4<f32>` to `&[f32]` HOT 1
- Matrix3 multiplication is 4x slower in 0.18 HOT 5
- Clippy warnings HOT 1
- Special method for combined invert + transpose for matrices
- [question] cannot subtract `Vector3<T>` from `Vector3<T> HOT 1
- Publish new versions to crates.io. HOT 2
- How to add the bytemuck feature to my package? HOT 1
- Re-add Frustum extraction
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cgmath.