Code Monkey home page Code Monkey logo

Comments (5)

kvark avatar kvark commented on May 11, 2024

Let me try. look_at doesn't really need the values directly, it just performs calculations based on the vectors you provide. Frustum::new on the other hand uses the given set of planes directly to store it. I do realize, however, that this is an implementation detail, so maybe we shouldn't reflect that in the interface.

from cgmath.

jeannekamikaze avatar jeannekamikaze commented on May 11, 2024

Ok, so your general preference is to pass in stuff by reference to avoid copies then? I might be contributing with other minor pieces of code these days, so I'm trying to understand your coding guidelines. This is also my third day of Rust, so I am also using your library as a source of inspiration :)

from cgmath.

kvark avatar kvark commented on May 11, 2024

Yes, that was my impression. I'm not the best person to answer that though, so please wait for @bjz to get here.

from cgmath.

brendanzab avatar brendanzab commented on May 11, 2024

For constructors I normally go by value, but for methods by ref. This may or may not be the best way... I dunno.

from cgmath.

brendanzab avatar brendanzab commented on May 11, 2024

We are now moving to a by-value style - see #247

from cgmath.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.