onig v4.3.1 fails to build with rust 1.27.0 about rust-onig HOT 3 CLOSED

This should now be fixed by #98.

from rust-onig.

Thanks for this report. Unfortunately this crate hasn't had a very grown up policy towards minimum Rust version so far. It should do though. I can see two ways to solve this:

Treat compiler version as major brekaing change:

• Document the crate's minimum supported rustc version
• Publish a new major version with the same codebase
• Publish a new minor version which rolls Rust support back to 1.27
• Include a test compile wtih our stated minimum rustc version in CI

Treat compiler version as minior brekaing change:

• Document the crate's minimum supported rustc version
• Include a test compile with our stated minimum rustc version in CI

I had kind of always assumed people depended on crates with x.y version numbers and that compiler version changes were treated as minor version breaking changes in the Rust ecosystem. This appears to be BurntSushi's oppinion over on https://users.rust-lang.org/t/rust-version-requirement-change-as-semver-breaking-or-not/20980 (https://github.com/rust-lang/regex#minimum-rust-version-policy).

from rust-onig.

Thanks for the quick response!

from rust-onig.