Latest onig-sys fails to build on Travis about rust-onig HOT 11 CLOSED

Failed on Linux Mint 18

rustc 1.20.0-nightly (05b579766 2017-07-01)
binary: rustc
commit-hash: 05b5797664d6aeaa0c7d0606610f336fe0b57e97
commit-date: 2017-07-01
host: x86_64-unknown-linux-gnu
release: 1.20.0-nightly
LLVM version: 4.0

from rust-onig.

Thanks. This looks like it's caused by the upgrade to oniguruma 6.4.0. I'll investigate.

from rust-onig.

It looks like the Docs.rs build fails with the same error.

from rust-onig.

Frustratingly this doesn't fail on our own Travis build and I can't get it to fail locally. Even more frustratingly my charger has just given up and I'm out of battery. I think the commit which caused the issue is from b350d3. For some reason the header guards mustn't be interpreted properly and inttypes.h is being included twice.

from rust-onig.

I have now managed to reproduce this issue on a VM. Building onig from source, which itself compiles onig_sys, is fine. Building from the version downloaded from Crates.io fails. Looking at the version of oniguruma that exists in the Crates.io version I can't get it to build. Guessing it must have got corrupted somehow. It was uploaded on a particularly flaky Cornish internet connection.

I'll try re-publishing as 64.0.1 and see how that affects things.

from rust-onig.

Okay. I will wait.

from rust-onig.

A test build locally of trishume/syntect builds now against onig 1.4.1. It's the same source as 1.4.0, just re-uploaded. Not sure what went wrong.

Let me know if this fixes things @codeyash, @trishume. If not I'll re-open this issue.

from rust-onig.

@iwillspeak thanks! syntect's Travis build is working again!

That's super weird about re-uploading the same source and it working, maybe crates.io doesn't have checksums when it really should?

from rust-onig.

I guess so. I wondered if somehow or other it had uploaded a dirty version of the oniguruma source. I don't think that was the case though because I found what cargo had downloaded, cleaned it and still couldn't get it to build 😕 .

from rust-onig.

git clone
git pull

https://pastebin.com/raw/KqMP5zRU

Facing again. Please suggest

from rust-onig.

Hi @codeyash!

It looks like the problem you're having is different from the one discussed in this issue. In fact it looks to be a duplicate of #43.

The crate in this repository provides a wrapper around an underlying C library. In some cases that library is compiled from source and linked into your program for you as part of the onig_sys crate build. Rather than having a copy of the source of Oniguruma in this repository and having to keep it in sync we use a Git feature called submodules. Git submodules allow us to say 'take the contents of this other repository and put it in this folder'. By default just running git clone won't clone those submodules for you. You can force it to do so by running git submodule init --update. Rather than having to run this after each clone you can also run git clone --recursive https://github.com/rust-onig/rust-onig.

For more information about submodules you can take a look at the Git Book.

If you have any more questions about getting this crate to build after a clean checkout please raise them on #43.

from rust-onig.