Code Monkey home page Code Monkey logo

Comments (10)

AVS-Origami avatar AVS-Origami commented on July 30, 2024 1

You need the latest commit. Instead of this:

linfa-kernel = "0.6.1"

Use this:

linfa-kernel = { git = "https://github.com/rust-ml/linfa.git" }

from linfa.

xosxos avatar xosxos commented on July 30, 2024

I have the same issue. Seems like CsMat which is imported from sprs cannot implement std::ops:Mul for some reason. Multiplication of a CsMat with an ArrayView2 is the issue which was handled by the std::ops::Mul trait previously from what I can see. But for some reason this is now broken.

from linfa.

AVS-Origami avatar AVS-Origami commented on July 30, 2024

Yes. I tried creating a new CsMat in a test crate, and I was able to call mul() on it. So I think the issue is related to CsMat not liking linfa::Float as the generic.

from linfa.

AVS-Origami avatar AVS-Origami commented on July 30, 2024

I changed the start of the impl block to this:

impl<F: Float> Inner for CsMat<F> where 
    CsMat<F>: Mul {
        ...
}

which results in several errors that look like this:

error[E0277]: cannot multiply `CsMatBase<F, usize, Vec<usize>, Vec<usize>, Vec<F>>` by `CsMatBase<F, usize, Vec<usize>, Vec<usize>, Vec<F>>`
   --> algorithms/linfa-kernel/src/lib.rs:196:20
    |
196 | impl<'a, F: Float> Kernel<F> {
    |                    ^^^^^^^^^ no implementation for `CsMatBase<F, usize, Vec<usize>, Vec<usize>, Vec<F>> * CsMatBase<F, usize, Vec<usize>, Vec<usize>, Vec<F>>`
    |
    = help: the trait `Mul` is not implemented for `CsMatBase<F, usize, Vec<usize>, Vec<usize>, Vec<F>>`
    = help: the following other types implement trait `Mul<Rhs>`:
              <&'a CsMatBase<N, I, IpS, IS, DS, Iptr> as Mul<&'b ndarray::ArrayBase<DS2, Dim<[usize; 1]>>>>
              <&'a CsMatBase<N, I, IpS, IS, DS, Iptr> as Mul<&'b ndarray::ArrayBase<DS2, Dim<[usize; 2]>>>>
              <&'a CsMatBase<N, I, IpS1, IS1, DS1, Iptr> as Mul<&'b CsMatBase<N, I, IpS2, IS2, DS2, Iptr>>>
              <&'a CsMatBase<N, I, IpS1, IS1, DS1, Iptr> as Mul<&'b CsVecBase<IS2, DS2, N, I>>>
              <&'a CsMatBase<f32, I, IpStorage, IStorage, DStorage, Iptr> as Mul<f32>>
              <&'a CsMatBase<f64, I, IpStorage, IStorage, DStorage, Iptr> as Mul<f64>>
              <&'a CsMatBase<i16, I, IpStorage, IStorage, DStorage, Iptr> as Mul<i16>>
              <&'a CsMatBase<i32, I, IpStorage, IStorage, DStorage, Iptr> as Mul<i32>>
            and 8 others
note: required for `CsMatBase<F, usize, Vec<usize>, Vec<usize>, Vec<F>>` to implement `Inner`
   --> algorithms/linfa-kernel/src/inner.rs:60:16
    |
60  | impl<F: Float> Inner for CsMat<F> where 
    |                ^^^^^     ^^^^^^^^
61  |     CsMat<F>: Mul {
    |               --- unsatisfied trait bound introduced here

Maybe this helps to diagnose the issue.

from linfa.

bytesnake avatar bytesnake commented on July 30, 2024

Could be related to sparsemat/sprs#278

from linfa.

bytesnake avatar bytesnake commented on July 30, 2024

This is a regression introduced with the sprs::MulAcc trait in 0.11 https://github.com/sparsemat/sprs/blob/master/changelog.rst Can you try with latest commit?

from linfa.

AVS-Origami avatar AVS-Origami commented on July 30, 2024

It works now. Thanks!

from linfa.

jeff-hykin avatar jeff-hykin commented on July 30, 2024

I still get this issue. What version is the fix on?
Screen Shot 2023-07-06 at 11 40 34 AM

from linfa.

jeff-hykin avatar jeff-hykin commented on July 30, 2024

Thanks! @AVS-Origami

from linfa.

clime avatar clime commented on July 30, 2024

I;ve just opened sparsemat/sprs#330

from linfa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.