trait with a len() method but without is_empty() method about rust-clippy HOT 3 CLOSED

I agree with all of this except:

we won't need to care for the few remaining false positives, right?

I don't think false positives are something people should live with and suppress on a case-by-case basis.

from rust-clippy.

@tamird Thanks for the heads-up. Just to clarify: A false positive in this case would be using an item (trait or type impl) that has a .len(), but no .is_empty() method (and that would have been flagged by this lint). So I think the cost of suppressing the one or two stray false positives is outweighed by the benefit of the lint I have for issue #32 without method lookup.

Please note that this is only an interim solution until rustc_typeck is made accessible to third party lint writers. The process to do this has already begun, so it's only a matter of time until we can do the method lookup and get rid of the remaining false positives.

from rust-clippy.

Note that this crate is about lints, and false positives if not too common are okay.

A lot of the things here, like Box<Vec<T>> have legitimate uses too, but very few especially from a newbie perspective.

from rust-clippy.