Comments (5)
So basically suggest the usage of a union type instead of the trait object?
Yeah, I'm not sure what the heuristics should be either.
from rust-clippy.
I think @kmcallister is referring to fn foo<T: SomeTrait>(t: &T)
vs. fn foo(t: &SomeTrait)
rather than explicit ADTs.
from rust-clippy.
Oh, I see.
from rust-clippy.
It seems like the main requirement for this would be to look at every function declaration, such as fn foo(t: &SomeTrait)
, and then be able to determine that SomeTrait
is a trait and not a struct or enum. Once you have that info, you can choose to emit a lint or not.
Maybe the RLS could help with this? not sure.
from rust-clippy.
Detecting whether the argument is a trait object is easy. Since any generic type with a bound on a trait can be turned into a trait object of that type, this would be a trivial transformation. The issues with transforming a random function from dynamic dispatch to static dispatch is that someone might be using the function by passing it a trait object. They might not have a chance to do anything else. So we'd also need to add a ?Sized
bound.
In gennral you can convert any fn foo(t: &SomeTrait)
to fn foo<T: SomeTrait + ?Sized>(t: &T)
without breaking anything.
Additionally there are cases where we do not want to use static dispatch in order to reduce compiletimes of downstream crates.
from rust-clippy.
Related Issues (20)
- missing_transmute_annotations wrong order of Src and Dst HOT 1
- needless_borrows_for_generic_arg seems to have introduced suggestions that break compilation for 1.80.0 HOT 1
- `macro_metavars_in_unsafe` does not lint "without a statement".
- Slow and biased rounding
- unnecessary_lazy_evaluations suggests running `unsafe` code eagerly HOT 6
- redundant_locals incorrectly emitted when binding in new local scope for early drop
- Print_* family of lints fail to match on `async_trait` functions with a return value
- indexing does not trigger missing_panics_doc HOT 4
- declare_interior_mutable_const fires for static pointer types
- Lint against Arc<impl Copy> HOT 1
- duplicated_attributes: false positive with apistos crate
- Clippy to fix warnings when they are converted to errors HOT 1
- Incorrectly printed suggestion for `map(<f>).unwrap_or(false)` on multiple lines HOT 1
- regression: unnecessary_lazy_evaluations not triggered on thiserror enum variant
- Add lints to encourage use of specialized assert macros
- `cast_possible_truncation` could check whether floating point values are manually truncated (round, floor, ceil...) prior to cast HOT 1
- Cargo clippy --fix not working with 1.80.1 HOT 2
- `module_inception` false positive for private sub-module HOT 4
- Lint use of functions with underscore-prefixed names HOT 2
- Flag unnecessary visiblity attributes on nested functions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-clippy.