Comments (7)
I think that one should be simple enough to detect, and it's also easy to create a good warning. I'd catch all instances of if { Lit:bool } else { Lit:bool } and suggest a suitable replacement based on the literals.
I'll take a stab at it when I find some free time.
from rust-clippy.
Yep, it's pretty simple. Go ahead! :)
from rust-clippy.
I'd catch all instances of if { Lit:bool } else { Lit:bool } and suggest a suitable replacement based on the literals.
It'd be great to have a general, declarative way to express rules like that. Maybe something similar to Coccinelle.
from rust-clippy.
Technically it's just a single huge match statement (assuming syntax::ptr::P
doesn't get in the way) ;)
from rust-clippy.
It would be cool to do this with quotation:
fn check_expr(&mut self, cx: &Context, expr: &Expr) {
match *expr {
q!(if $e:expr { $a:lit } else { $b:lit }) => ...
I think this is actually achievable now, if you replace the whole match
by an invocation of a procedural macro, similar to html5ever's match_token!
.
from rust-clippy.
A macro should be able to generate code to deal with ptr::P
, as irritating as it sometimes is. But until we have this macro, I'm going to write the lint the traditional way.
from rust-clippy.
Done. The warnings could give more specific directions (they are a bit abstract for a newbie), but it works, and it's late now; I guess, I'll revisit them later.
from rust-clippy.
Related Issues (20)
- needless_borrows_for_generic_arg seems to have introduced suggestions that break compilation for 1.80.0 HOT 1
- `macro_metavars_in_unsafe` does not lint "without a statement".
- Slow and biased rounding
- unnecessary_lazy_evaluations suggests running `unsafe` code eagerly HOT 6
- redundant_locals incorrectly emitted when binding in new local scope for early drop
- Print_* family of lints fail to match on `async_trait` functions with a return value
- indexing does not trigger missing_panics_doc HOT 4
- declare_interior_mutable_const fires for static pointer types
- Lint against Arc<impl Copy> HOT 1
- duplicated_attributes: false positive with apistos crate
- Clippy to fix warnings when they are converted to errors HOT 1
- Incorrectly printed suggestion for `map(<f>).unwrap_or(false)` on multiple lines HOT 1
- regression: unnecessary_lazy_evaluations not triggered on thiserror enum variant
- Add lints to encourage use of specialized assert macros
- `cast_possible_truncation` could check whether floating point values are manually truncated (round, floor, ceil...) prior to cast HOT 1
- Cargo clippy --fix not working with 1.80.1 HOT 2
- `module_inception` false positive for private sub-module HOT 4
- Lint use of functions with underscore-prefixed names HOT 2
- Flag unnecessary visiblity attributes on nested functions HOT 1
- Cargo clippy report warnings from macros when using quote_spanned
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-clippy.