if x { true } else { false } about rust-clippy HOT 7 CLOSED

I think that one should be simple enough to detect, and it's also easy to create a good warning. I'd catch all instances of if { Lit:bool } else { Lit:bool } and suggest a suitable replacement based on the literals.

I'll take a stab at it when I find some free time.

from rust-clippy.

Yep, it's pretty simple. Go ahead! :)

from rust-clippy.

I'd catch all instances of if { Lit:bool } else { Lit:bool } and suggest a suitable replacement based on the literals.

It'd be great to have a general, declarative way to express rules like that. Maybe something similar to Coccinelle.

from rust-clippy.

Technically it's just a single huge match statement (assuming syntax::ptr::P doesn't get in the way) ;)

from rust-clippy.

It would be cool to do this with quotation:

fn check_expr(&mut self, cx: &Context, expr: &Expr) {
    match *expr {
        q!(if $e:expr { $a:lit } else { $b:lit }) => ...

I think this is actually achievable now, if you replace the whole match by an invocation of a procedural macro, similar to html5ever's match_token!.

from rust-clippy.

A macro should be able to generate code to deal with ptr::P, as irritating as it sometimes is. But until we have this macro, I'm going to write the lint the traditional way.

from rust-clippy.

Done. The warnings could give more specific directions (they are a bit abstract for a newbie), but it works, and it's late now; I guess, I'll revisit them later.

from rust-clippy.