Code Monkey home page Code Monkey logo

Comments (5)

alexcrichton avatar alexcrichton commented on August 15, 2024

How are we going to manage that in this repository?

Having a dev-dependency on regex_macros only kicks in during development, so publication to crates.io for regex should work fine on and off nightly. It just means that if you use regex_macros with stable rust you'll get some compile errors.

Is it possible for them to cohabitate?

I think the implication is that this repository must be developed with nightly, but that's not necessarily the end of the world!

Methinks this has to be removed or changed, because teasing users with such an awesome feature is going to make them mad. :-)

I'd be fine with this!

Of third concern is the programming shootout.

Oh I meant to do this, I'd be fine moving the shootout benchmark into this repo under benches

N.B. @erickt is working on rust-syntex, which I think ought to support use of the regex! macro

That'd be pretty sweet to get the compile time optimizations on stable rust so quickly!

from regex.

BurntSushi avatar BurntSushi commented on August 15, 2024

I think the implication is that this repository must be developed with nightly, but that's not necessarily the end of the world!

I'm definitely OK with this, but how do we test the regex crate on Rust 1.0 stable? i.e., Because of the dev-dependency on regex_macros, cargo test on Rust 1.0 stable should fail I think.

from regex.

BurntSushi avatar BurntSushi commented on August 15, 2024

Oh, and I'll bring the shootout benchmark back into this repo tonight. :-) Happy to see it live on!

from regex.

alexcrichton avatar alexcrichton commented on August 15, 2024

To test regex on stable we would probably want to move all the regex! tests into the regex_macros crate so testing the regex crate would only test Regex::new and testing regex_macros would test regex!

from regex.

BurntSushi avatar BurntSushi commented on August 15, 2024

I think all of the issues listed here have been fixed in 2d0e77a.

from regex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.