Bug: `is_system` erroneously reports that a library is a system library in some cases. about pkg-config-rs HOT 6 OPEN

Does configuring this crate work?

from pkg-config-rs.

It doesn't work, since the is_system check on this row: https://github.com/alexcrichton/pkg-config-rs/blob/master/src/lib.rs#L433 prevents static build even if the flags are set.

from pkg-config-rs.

Sounds like a bug to fix then!

from pkg-config-rs.

I'll look into it in the near future!

from pkg-config-rs.

#37 Sent a PR.

I left the check with empty directory list as is, because it seems reasonable to think a library is a system lib if no search path is specified. But I fixed two other problems.

from pkg-config-rs.

There's still one problem:

The is_system check prevents library from being linked statically. But if people use system-provided musl-dev libs, they are in the system dirs (for example, /usr/lib/x86_64-linux-musl/), and it's reasonable to link against them.

I don't know if there even exists a simple, non-distro specific heuristic that is able to prevent obviously wrong choices while allowing the correct ones. (One of reasonable candidates is checking whether the path contains word "musl"; that works at least on Debian and Arch, but that would be not only distro-specific, but also target-specific. Not sure if we even have other static targets than musl, though.)

from pkg-config-rs.