Code Monkey home page Code Monkey logo

Comments (10)

yshui avatar yshui commented on August 15, 2024 1

Maybe we can remove it now?

from pkg-config-rs.

sdroege avatar sdroege commented on August 15, 2024 1

Possibly, but most likely it will break someone's setup :)

I'd like to do a pkg-config 0.5 release in the future that drops all these weird hacks that come without explanation and instead rely solely on the default pkg-config behavior (and if needed people can override that with the pkg-config environment variables, we don't have to set them ourselves, or with a wrapper script). Currently this crate is rather opinionated about the build environment, which causes a couple of problems.

from pkg-config-rs.

otavio avatar otavio commented on August 15, 2024 1

@sdroege, any news in providing a way to get it linking to static libraries more easily?

from pkg-config-rs.

jirutka avatar jirutka commented on August 15, 2024 1

@alexcrichton, can you please remove this “feature” or at least allow us to disable it via an environment variable? It is clearly wrong and based on some weird assumption that doesn’t hold universally. The workaround with SYSROOT=/dummy cannot be used when cross-compiling.

from pkg-config-rs.

sdroege avatar sdroege commented on August 15, 2024

That seems to come from 9a57960 by @alexcrichton . I don't understand the rationale given in the commit message though. Maybe he can explain :)

from pkg-config-rs.

alexcrichton avatar alexcrichton commented on August 15, 2024

Hm given how that was around 7 years ago, I don't really remember much about the context... 99% of the time commits like that were "this fixes a bug somewhere" and I didn't do a great job of documenting what bug was fixed where. I don't currently remember what bug was fixed either, so sorry but I don't think I can be of much help :(

from pkg-config-rs.

cjordan avatar cjordan commented on August 15, 2024

I've just come up against this issue. Is there something I could do to help accelerate the next big release of pkg-config?

from pkg-config-rs.

toxeus avatar toxeus commented on August 15, 2024

@sdroege wrote:

Possibly, but most likely it will break someone's setup :)

Maybe we can introduce another env var to disable the current behavior that refuses to statically link system libs? A quick and quite dirty workaround already exists by setting, e.g. SYSROOT=/asdf but it would be nicer to have something explicit rather than relying on such side-effects.

from pkg-config-rs.

toxeus avatar toxeus commented on August 15, 2024

@sdroege established a plan on how to move forward but nothing happened since 2 years.

from pkg-config-rs.

teythoon avatar teythoon commented on August 15, 2024

This affects our Nettle bindings as well: https://gitlab.com/sequoia-pgp/nettle-sys/-/issues/16

from pkg-config-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.