Comments (4)
Can i work on this issue with some help, I don't know where I should start?
from gccrs.
@badumbatish I'll try writing a starting guide here today but I'm very busy, please ping me on Zulip if you get to working on this and I still haven't written anything
i'll probably work on this on the weekend, no worries
from gccrs.
alright, so here's how I would go about solving this. first, we need to make sure that visibility modifiers are actually parsed for extern type nodes (AST::ExternalTypeItem
) - you can do that by looking at our parser, in rust-parse-impl.h
, and searching for ExternalTypeItem
, as there will be only one function which will create and return these nodes.
if you're sure that visibility is parsed (e.g. if the parsing function is called with a visibility, or that we call parse_visibility
in the parsing function), then you need to ensure that this visibility is being assigned to the ExternalTypeItem
. Check the class definition, make sure a visibility member exists and is used, etc.
now finally, the next and last step is to make sure that the AST visibility is correctly lowered to an HIR visibility when we lower our AST::ExternalTypeItem
into an HIR::ExternalTypeItem
. you'll have to find the visitor responsible for performing that operation and make sure the visibility is lowered and transferred properly.
once that's done, in a later PR/issue we'll check that the visibility modifiers are actually working for external types and not just ignored - but that's for later and concerns another part of the compiler :)
from gccrs.
@badumbatish I'll try writing a starting guide here today but I'm very busy, please ping me on Zulip if you get to working on this and I still haven't written anything
from gccrs.
Related Issues (20)
- Cannot resolve generics declared later in the generic list
- Add `unsize` lang item
- Unknown attribute `#[rustc_diagnostic_item]`
- Unknown attribute `#[track_caller]`
- Add `coerce_unsized` lang item
- Add `dispatch_from_dyn` lang item
- Add `unsafe_cell` lang item
- Negative implementations complain about missing methods HOT 2
- Invalid "unconstrained type parameter" error
- `Deref` and `DerefMut` cause ambiguity issues when resolving HOT 3
- Invalid "duplicate definitions" error in `Cell<T>` implementation
- Impl block after macro expansion triggers macro expansion recursion limit HOT 1
- Unknown reference for resolved name `Self` in impl of `Clone` for `!`
- ICE when implementing `Default` for `()`
- Add `va_list` lang item
- Name resolve `#[fundamental]` attribute properly
- Handle list of const intrinsics properly for 1.49
- Add `discriminant_kind` lang item
- Add `#[rustc_specialization_trait]` attribute HOT 1
- Add `#[rustc_unsafe_specialization_marker]` attribute
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gccrs.